Set up tokens for layout/container styles #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-maertens
commented
Nov 9, 2023
There was a problem hiding this comment.
This is the page container in the backend.
sergei-maertens
commented
Nov 9, 2023
There was a problem hiding this comment.
This is the page footer in the backend.
sergei-maertens
commented
Nov 9, 2023
There was a problem hiding this comment.
This is the page header in the backend.
sergei-maertens
commented
Nov 9, 2023
There was a problem hiding this comment.
This is the page container in the backend.
sergei-maertens
commented
Nov 9, 2023
There was a problem hiding this comment.
SDK app container, containing the useful bit, language switcher and debug div for development.
sergei-maertens
commented
Nov 9, 2023
There was a problem hiding this comment.
Container for form body + (optional) progress indicator
This was referenced Nov 9, 2023
…e footer This sets up the out-of-the-box design tokens supported by the upstream component, and additionally adds responsive token values for the Open Forms' specific extensions.
Added the default/fallback tokens and set up token aliases while deprecating old tokens. The deprecated tokens will be removed in Open Forms 3.0.
…/mobile view The utrecht-page/utrecht-page-content design tokens replace the layout 'component' we had in the backend.
sergei-maertens
force-pushed
the
refactor/3178-tokens-for-backend-styles
branch
from
3c49834 to
9ce92f2
Compare
SilviaAmAm
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly closes open-formulieren/open-forms#3178
Required for SDK changes
Required for backend changes