Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use description per option in selectboxes and radio components #483

Closed

Comments

@SilviaAmAm
Copy link
Contributor

SilviaAmAm commented Jul 4, 2023

DH Taiga issue 540

This should happen both in the native components and the formio templates.

image

@sergei-maertens
Copy link
Member

I don't think this is currently possible in the backend because options only allow specifying label + value and there's no input now for additional descriptions.

@nikkiysendoorn1
Copy link
Contributor

I finished this in the frontend. There should be an extra description field in the admin.

@joeribekker joeribekker moved this from In Progress to Todo in Development Mar 6, 2024
@sergei-maertens
Copy link
Member

sergei-maertens commented Mar 11, 2024

Specified a bit more in detail what needs to happen in the different repositories:

  • In the https://github.com/open-formulieren/types repository:
    • add the description property to the Option interface so that the formio builder and future formio renderer know that this property exists.
    • ensure that this property is marked as translatable at the type level (option.openForms.translations.description should be allowed, same as option.openForms.translations.label)
  • In the https://github.com/open-formulieren/formio-builder repository:
    • Ensure that for radio/checkbox components the description can be entered by form designers (currently you can only enter value and label)
    • Ensure that the translations for the description field can be entered on the translation tab
  • In the https://github.com/open-formulieren/open-forms-sdk repository:
    • Update the checkbox/radio EJS formio templates to make sure the descriptions are displayed
    • Ensure that the correct NL Design System class names and markup are used
    • Update the React component for radio too (which is separate from the formio component) with the same constraints as above

Backend:

  • Ensure that the description of the option is localized with the active language

nikkiysendoorn1 added a commit that referenced this issue Mar 11, 2024
nikkiysendoorn1 added a commit that referenced this issue Mar 11, 2024
nikkiysendoorn1 added a commit that referenced this issue Mar 11, 2024
nikkiysendoorn1 added a commit that referenced this issue Mar 11, 2024
@github-project-automation github-project-automation bot moved this from Implemented to In Progress in Development Mar 11, 2024
@nikkiysendoorn1 nikkiysendoorn1 moved this from In Progress to Implemented in Development Mar 18, 2024
nikkiysendoorn1 added a commit that referenced this issue Mar 18, 2024
nikkiysendoorn1 added a commit that referenced this issue Mar 18, 2024
nikkiysendoorn1 added a commit that referenced this issue Mar 19, 2024
…-per-option

✨ [#483] add description to selectboxes and radio option
@github-project-automation github-project-automation bot moved this from Implemented to Done in Development Mar 19, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Development Mar 19, 2024
@nikkiysendoorn1 nikkiysendoorn1 moved this from In Progress to Implemented in Development Mar 19, 2024
@github-project-automation github-project-automation bot moved this from Implemented to Done in Development Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment