✨ [#483] add description to selectboxes and radio option #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #658 +/- ##
==========================================
- Coverage 69.78% 69.36% -0.42%
==========================================
Files 207 207
Lines 4335 4335
Branches 1155 1155
==========================================
- Hits 3025 3007 -18
- Misses 1310 1328 +18 ☔ View full report in Codecov by Sentry. |
nikkiysendoorn1
force-pushed
the
future/483-description-per-option
branch
2 times, most recently
from
d8263d5 to
2f7684e
Compare
sergei-maertens
requested changes
Mar 11, 2024
Comment on lines
+25
to
+31
| {% if (item.description) { %} | ||
| <div class="utrecht-description utrecht-form-description--openforms"> | ||
| <p class="utrecht-form-field-description utrecht-form-field__description"> | ||
| {{ item.description }} | ||
| </p> | ||
| </div> | ||
| {% } %} |
There was a problem hiding this comment.
I'm missing the aria-describedby on the inputs & the IDs on this element.
Additionally, I don't think the utrecht-form-field__description being nested makes it properly targettable with the CSS grid grid-area directives, so I'm not sure about how correct this markup is 🤔
Looking at https://nl-design-system.github.io/utrecht/storybook/?path=/story/css-form-field-radio-group--description, the markup seems to be:
<div class="utrecht-form-field-description utrecht-form-field__description"> {{ item.description }} </div>which works well with their grid layout.
nikkiysendoorn1
force-pushed
the
future/483-description-per-option
branch
from
2f7684e to
85e5f1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.