[OF#3443] Date validation #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…where date is entered manually
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #548 +/- ##
==========================================
+ Coverage 70.18% 70.48% +0.30%
==========================================
Files 206 207 +1
Lines 4263 4290 +27
Branches 1154 1163 +9
==========================================
+ Hits 2992 3024 +32
+ Misses 1238 1236 -2
+ Partials 33 30 -3
☔ View full report in Codecov by Sentry. |
…his... The jest test didnt go anywhere (the method that creates a form with a date component returns a promise that never resolves). In storybook you can interact manually with a component with a minDate and see that it works. It's something.
There was a problem hiding this comment.
Perhaps we can add some jest unit tests for the validator itself so we at least have coverage on them?
There was a problem hiding this comment.
This is a good idea, I will try!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-formulieren/open-forms#3443
Depends on open-formulieren/open-forms#3479
I give up on the tests 😢