Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OF#3443] Date validation #548
[OF#3443] Date validation #548
Changes from all commits
5c2bc52
01cf715
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we can add some jest unit tests for the validator itself so we at least have coverage on them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good idea, I will try!
Check warning on line 8 in src/formio/validators/minMaxDateValidator.js
Codecov / codecov/patch
src/formio/validators/minMaxDateValidator.js#L8
Check warning on line 11 in src/formio/validators/minMaxDateValidator.js
Codecov / codecov/patch
src/formio/validators/minMaxDateValidator.js#L11
Check warning on line 21 in src/formio/validators/minMaxDateValidator.js
Codecov / codecov/patch
src/formio/validators/minMaxDateValidator.js#L19-L21
Check warning on line 23 in src/formio/validators/minMaxDateValidator.js
Codecov / codecov/patch
src/formio/validators/minMaxDateValidator.js#L23
Check warning on line 26 in src/formio/validators/minMaxDateValidator.js
Codecov / codecov/patch
src/formio/validators/minMaxDateValidator.js#L26
Check warning on line 34 in src/formio/validators/minMaxDateValidator.js
Codecov / codecov/patch
src/formio/validators/minMaxDateValidator.js#L34
Check warning on line 41 in src/formio/validators/minMaxDateValidator.js
Codecov / codecov/patch
src/formio/validators/minMaxDateValidator.js#L41
Check warning on line 43 in src/formio/validators/minMaxDateValidator.js
Codecov / codecov/patch
src/formio/validators/minMaxDateValidator.js#L43