Skip to content

Commit

Permalink
lint and codeowners
Browse files Browse the repository at this point in the history
  • Loading branch information
lmolkova committed Sep 29, 2023
1 parent 4126e01 commit 8ccf219
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 6 deletions.
10 changes: 7 additions & 3 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@
#
# Learn about membership in OpenTelemetry community:
# https://github.com/open-telemetry/community/blob/main/community-membership.md
#
#
# Learn about CODEOWNERS file format:
#
# Learn about CODEOWNERS file format:
# https://help.github.com/en/articles/about-code-owners
#

# Global owners, will be the owners for everything in the repo. Membership is tracked via https://github.com/open-telemetry/community/blob/main/community-members.md
# Global owners, will be the owners for everything in the repo. Membership is tracked via https://github.com/open-telemetry/community/blob/main/community-members.md
* @open-telemetry/specs-semconv-maintainers @open-telemetry/specs-semconv-approvers

# Schemas and schema file tooling
Expand Down Expand Up @@ -41,4 +41,8 @@
/docs/resource/host.md @open-telemetry/specs-semconv-approvers @open-telemetry/semconv-system-approvers
/model/resource/host.yaml @open-telemetry/specs-semconv-approvers @open-telemetry/semconv-system-approvers

# .NET semantic conventions approvers
/model/metrics/dotnet/ @open-telemetry/specs-semconv-approvers @open-telemetry/semconv-dotnet-approvers
/docs/dotnet/ @open-telemetry/specs-semconv-approvers @open-telemetry/semconv-dotnet-approvers

# TODO - Add semconv area experts
8 changes: 5 additions & 3 deletions docs/dotnet/dotnet-http-metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ Client request duration measures time it takes to receive response headers and d
This metric follows common [http.client.request.duration](../http/http-metrics.md#metric-httpclientrequestduration) definition.

Notes:
- Meter name: `System.Net.Http`

- Meter name is `System.Net.Http`
- Metric added in .NET 8.0
- When `error.type` attribute is reported, it contains one of [HTTP Request errors](https://github.com/dotnet/runtime/blob/main/src/libraries/System.Net.Http/src/System/Net/Http/HttpRequestError.cs), a full exception type, or a string representation of received status code.

Expand Down Expand Up @@ -237,10 +238,11 @@ Measures time to last byte. This metric follows common [http.server.request.dura

Notes:

- Meter name: `Microsoft.AspNetCore.Hosting`
- Meter name is `Microsoft.AspNetCore.Hosting`
- Metric added in ASP.NET Core 8.0
- Opt-in `server.address` and `server.port` attributes are not reported
- Additional attributes

- The `aspnetcore.request.is_unhandled` boolean attribute is reported when the request was **not** handled by the application pipeline. It's skipped otherwise.
- The `exception.type` string attribute is reported if and only if the request ended with an error. It includes full exception type. <-TODO: can we change it to `error.type` ?

Expand All @@ -250,7 +252,7 @@ Measures the number of HTTP requests that are currently active on the server. Th

Notes:

- Meter name: `Microsoft.AspNetCore.Hosting`
- Meter name is `Microsoft.AspNetCore.Hosting`
- Opt-in `server.address` and `server.port` attributes are not reported
- Metric added in ASP.NET Core 8.0

Expand Down

0 comments on commit 8ccf219

Please sign in to comment.