Skip more tests that needs investigations #6
Conversation
meaksh
changed the title
|
|
||
| "tests/pytests/functional/modules/test_x509_v2.py::test_create_private_key[ed25519]", # Needs investigation: Fails only with Salt Bundle - cryptography.exceptions.UnsupportedAlgorithm: ed25519 is not supported by t... | ||
| "tests/pytests/functional/modules/test_x509_v2.py::test_create_private_key[ed448]", # Needs investigation: Fails only with Salt Bundle - cryptography.exceptions.UnsupportedAlgorithm: ed448 is not supported by thi... | ||
| "tests/pytests/functional/modules/test_x509_v2.py::test_create_private_key_with_passphrase[ed25519]", # Needs investigation: Fails only with Salt Bundle - cryptography.exceptions.UnsupportedAlgorithm: ed25519 is not supported by t... | ||
| "tests/pytests/functional/modules/test_x509_v2.py::test_create_private_key_with_passphrase[ed448]", # Needs investigation: Fails only with Salt Bundle - cryptography.exceptions.UnsupportedAlgorithm: ed448 is not supported by thi... |
There was a problem hiding this comment.
The actual root cause of these tests fails is the missing algorithms in openssl library on the client, so there is no way to fix it on the salt level. I think these failing tests were fixed with openSUSE/salt#646, are they still failing?
There was a problem hiding this comment.
I see these tests still failing for Leap 15.5 with Salt Bundle, where the mentioned fixes should be available: https://ci.suse.de/user/manager/my-views/view/Salt%20Shaker/job/manager-salt-shaker-products-testing-leap155-bundle/
Host: salt-shaker-products-testing-leap155-bundle.mgr.suse.de
I haven't debug the tests yet.
There was a problem hiding this comment.
I see what's the problem. I haven't fixed all the tests this way, these two are marked as slow and seems I missed them. But better to fix them instead of adding as skip, I think.
There was a problem hiding this comment.
Fixed in openSUSE/salt@7daf461 - we can remove this from the PR.
|
|
||
| "tests/pytests/functional/modules/test_x509_v2.py::test_create_private_key[ed25519]", # Needs investigation: Fails only with Salt Bundle - cryptography.exceptions.UnsupportedAlgorithm: ed25519 is not supported by t... | ||
| "tests/pytests/functional/modules/test_x509_v2.py::test_create_private_key[ed448]", # Needs investigation: Fails only with Salt Bundle - cryptography.exceptions.UnsupportedAlgorithm: ed448 is not supported by thi... | ||
| "tests/pytests/functional/modules/test_x509_v2.py::test_create_private_key_with_passphrase[ed25519]", # Needs investigation: Fails only with Salt Bundle - cryptography.exceptions.UnsupportedAlgorithm: ed25519 is not supported by t... | ||
| "tests/pytests/functional/modules/test_x509_v2.py::test_create_private_key_with_passphrase[ed448]", # Needs investigation: Fails only with Salt Bundle - cryptography.exceptions.UnsupportedAlgorithm: ed448 is not supported by thi... |
There was a problem hiding this comment.
Fixed in openSUSE/salt@7daf461 - we can remove this from the PR.
| @@ -93,6 +93,7 @@ unit = [ | |||
| ] | |||
| integration = [ | |||
| "tests/integration/cli/test_custom_module.py::SSHCustomModuleTest::test_ssh_custom_module", # Needs investigation: Fails only with Salt Bundle | |||
| "tests/integration/cli/test_custom_module.py::SSHCustomModuleTest::test_ssh_regular_module", # Needs investigation: Fails only with Salt Bundle | |||
There was a problem hiding this comment.
Where does this fail? We're getting green on Salt Bundle pipelines (with obvious exceptions, e.g. Debian 11 or Ubuntu 24.04).
Following-up #5, this PR adds a couple more detected failing tests to the skiplist
We need to investigate these tests failures further and then fix them in the testsuite itself. Since fixes are not obvious, we add them here for now until fixed in the testsuite (to allow green executions for now until we fix these detected issues)
Getting rid of these skiplist entries is tracked here: https://github.com/SUSE/spacewalk/issues/23536