Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip more tests that needs investigations #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Skip more tests that needs investigations #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions skipped_tests.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ unit = [
]
integration = [
"tests/integration/cli/test_custom_module.py::SSHCustomModuleTest::test_ssh_custom_module", # Needs investigation: Fails only with Salt Bundle
"tests/integration/cli/test_custom_module.py::SSHCustomModuleTest::test_ssh_regular_module", # Needs investigation: Fails only with Salt Bundle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this fail? We're getting green on Salt Bundle pipelines (with obvious exceptions, e.g. Debian 11 or Ubuntu 24.04).

"tests/integration/cli/test_custom_module.py::SSHCustomModuleTest::test_ssh_sls_with_custom_module", # Needs investigation: Fails only with Salt Bundle
"tests/integration/loader/test_ext_modules.py", # Make pytest to stuck in sle15sp1 classic pkg
"tests/integration/modules/test_cmdmod.py::CMDModuleTest::test_which_bin",
Expand Down Expand Up @@ -153,6 +154,11 @@ functional = [
"tests/pytests/functional/runners/test_winrepo.py::test_legacy_update_git_repos",
"tests/pytests/functional/runners/test_winrepo.py::test_update_git_repos",
"tests/pytests/functional/states/test_pip_state.py::test_pip_installed_name_test_mode",

"tests/pytests/functional/modules/test_x509_v2.py::test_create_private_key[ed25519]", # Needs investigation: Fails only with Salt Bundle - cryptography.exceptions.UnsupportedAlgorithm: ed25519 is not supported by t...
"tests/pytests/functional/modules/test_x509_v2.py::test_create_private_key[ed448]", # Needs investigation: Fails only with Salt Bundle - cryptography.exceptions.UnsupportedAlgorithm: ed448 is not supported by thi...
"tests/pytests/functional/modules/test_x509_v2.py::test_create_private_key_with_passphrase[ed25519]", # Needs investigation: Fails only with Salt Bundle - cryptography.exceptions.UnsupportedAlgorithm: ed25519 is not supported by t...
"tests/pytests/functional/modules/test_x509_v2.py::test_create_private_key_with_passphrase[ed448]", # Needs investigation: Fails only with Salt Bundle - cryptography.exceptions.UnsupportedAlgorithm: ed448 is not supported by thi...
Comment on lines +157 to +161
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual root cause of these tests fails is the missing algorithms in openssl library on the client, so there is no way to fix it on the salt level. I think these failing tests were fixed with openSUSE/salt#646, are they still failing?

Copy link
Member Author

@meaksh meaksh Jul 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see these tests still failing for Leap 15.5 with Salt Bundle, where the mentioned fixes should be available: https://ci.suse.de/user/manager/my-views/view/Salt%20Shaker/job/manager-salt-shaker-products-testing-leap155-bundle/

Host: salt-shaker-products-testing-leap155-bundle.mgr.suse.de

I haven't debug the tests yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what's the problem. I haven't fixed all the tests this way, these two are marked as slow and seems I missed them. But better to fix them instead of adding as skip, I think.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in openSUSE/salt@7daf461 - we can remove this from the PR.

"tests/pytests/functional/states/test_pip_state.py::test_pip_installed_pkgs_test_mode",
"tests/pytests/functional/states/test_x509_v2.py::test_certificate_managed_backup[1234-False-der]", # Needs investigation: Fails only with Salt Bundle - assert False is True
"tests/pytests/functional/states/test_x509_v2.py::test_certificate_managed_backup[1234-False-pem]", # Needs investigation: Fails only with Salt Bundle - assert False is True
Expand Down