Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add cmd line mysql ssl options, fixes RHOAIENG-3337 #4

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

dhirajsb
Copy link

Description

Adds command line options to configure mysql ssl connection.

How Has This Been Tested?

Verifies that mlmd tries to connect to mysql using ssl options.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is working and the change makes sense to me, thanks @dhirajsb

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per red-hat-data-services#3 (review) I believe would be meaningful as well to have @isinyaaa to chime in :)

Comment on lines +372 to +374
DEFINE_bool(mysql_config_verify_server_cert, false,
"This parameter enables verification of the server certificate "
" against the host name used when connecting to the server.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DEFINE_bool(mysql_config_verify_server_cert, false,
"This parameter enables verification of the server certificate "
" against the host name used when connecting to the server.");
DEFINE_bool(mysql_config_verify_server_cert, false,
"When certificates are provided, this parameter enables verification of the server certificate "
" against the host name used when connecting to the server.");

I know we discussed this, just re-reporting for archival purposes.

@tarilabs tarilabs requested a review from isinyaaa February 20, 2024 08:09
Copy link

@isinyaaa isinyaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dhirajsb dhirajsb merged commit b222cc1 into opendatahub-io:master Feb 20, 2024
1 check passed
@dhirajsb dhirajsb deleted the mysql-ssl-options branch February 20, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants