fix: add cmd line mysql ssl options, fixes RHOAIENG-3337 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarilabs
approved these changes
Feb 17, 2024
Comment on lines
+372
to
+374
| DEFINE_bool(mysql_config_verify_server_cert, false, | ||
| "This parameter enables verification of the server certificate " | ||
| " against the host name used when connecting to the server."); |
There was a problem hiding this comment.
Suggested change
| DEFINE_bool(mysql_config_verify_server_cert, false, | |
| "This parameter enables verification of the server certificate " | |
| " against the host name used when connecting to the server."); | |
| DEFINE_bool(mysql_config_verify_server_cert, false, | |
| "When certificates are provided, this parameter enables verification of the server certificate " | |
| " against the host name used when connecting to the server."); |
wdyt, given this parameter takes effects only iff ssl/certificates parameters are provided?
There was a problem hiding this comment.
I think it's fine as it is. The description comes from the proto declaration anyway.
lampajr
requested changes
Feb 18, 2024
There was a problem hiding this comment.
The change itself looks good to me but shouldn't we put this change in opendatahub-io/ml-metadata first and then sync the master branch? As we are already doing with opendatahub-io#2
Keep in mind that rhoai-2.7 became a test branch as we did not include it in the 2.7 release, therefore I would suggest to apply the change on master and then we will branch out from that one
* Fix MLMD build on Fedora Signed-off-by: Andrea Lamparelli <[email protected]> * Revert zetasql upgrade and switch to ubi8 (google#2) --------- Signed-off-by: Andrea Lamparelli <[email protected]>
dhirajsb
force-pushed
the
mysql-ssl-options
branch
from
95738cf to
1360342
Compare
|
Closing this PR to re-open it in ODH repo. |
|
Reopened as opendatahub-io#4 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.