fix: add cmd line mysql ssl options, fixes RHOAIENG-3337 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarilabs
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
per red-hat-data-services#3 (review) I believe would be meaningful as well to have @isinyaaa to chime in :)
Comment on lines
+372
to
+374
| DEFINE_bool(mysql_config_verify_server_cert, false, | ||
| "This parameter enables verification of the server certificate " | ||
| " against the host name used when connecting to the server."); |
There was a problem hiding this comment.
Suggested change
| DEFINE_bool(mysql_config_verify_server_cert, false, | |
| "This parameter enables verification of the server certificate " | |
| " against the host name used when connecting to the server."); | |
| DEFINE_bool(mysql_config_verify_server_cert, false, | |
| "When certificates are provided, this parameter enables verification of the server certificate " | |
| " against the host name used when connecting to the server."); |
I know we discussed this, just re-reporting for archival purposes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds command line options to configure mysql ssl connection.
How Has This Been Tested?
Verifies that mlmd tries to connect to mysql using ssl options.
Merge criteria: