Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.redhat.com/browse/RHOAIENG-3496
Description
Fixes an issue introduced with the string escaping:
I experienced he following issue by starting the mlmd server (image
quay.io/opendatahub/mlmd-grpc-server:main-ec2c7b1
) together withsqlite
configuration.The sqlite config I used is the same used in model registry: https://github.com/opendatahub-io/model-registry/blob/main/test/config/ml-metadata/conn_config.pb for testing purposes.
Since I am not expert on the codebase I don't know if this fix is going to revert the issue fixed with #2
How Has This Been Tested?
Build local image and run model registry test using the
sqlite
configuration.Merge criteria: