-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New link on studio home to Taxonomy list and flag added [FC-0036] #33439
feat: New link on studio home to Taxonomy list and flag added [FC-0036] #33439
Conversation
Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
d0a7ef4
to
16bdc8a
Compare
9fede5d
to
935d42f
Compare
91c3f41
to
b16c733
Compare
091dd8e
to
41f8358
Compare
41f8358
to
731722b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ChrisChV ! Good work here!
- I read through the code
- I followed the test instructions and ran the code locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks! Just to confirm, it's safe to merge this now even with old versions of the MFE that don't yet have the new taxonomies list page, right? Because everything is behind a waffle flag?
You'll need to merge master into this branch or rebase, then I can merge tomorrow.
@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
Added a new waffle flag to enable a new link on Studio Home to redirect to the Taxonomy List page on the Course authoring MFE.
Supporting information
Testing instructions
Setup
ENABLE_TAGGING_TAXONOMY_PAGES
for the frontend-app-course-authoring by adding ENABLE_TAGGING_TAXONOMY_PAGES=true to devstack/microfrontend.yml.new_studio_mfe.use_tagging_taxonomy_list_page
flag on studio.1.I
and1.III
make requirements
and restart the CMS server.Testing
Taxonomies
link next toLibraries
linkOther information
Before merge