Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New link on studio home to Taxonomy list and flag added [FC-0036] #33439

Merged

Conversation

ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Oct 6, 2023

Description

Added a new waffle flag to enable a new link on Studio Home to redirect to the Taxonomy List page on the Course authoring MFE.

Supporting information

Testing instructions

Setup

Testing

  • Go to Studio Home with staff user.
  • Click on the Taxonomies link next to Libraries link

image

Other information

Before merge

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 6, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 6, 2023

Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@ChrisChV ChrisChV marked this pull request as draft October 6, 2023 19:48
@ChrisChV ChrisChV force-pushed the chris/FAL-3522-taxonomy-list-page branch from d0a7ef4 to 16bdc8a Compare October 12, 2023 22:50
@ChrisChV ChrisChV marked this pull request as ready for review October 13, 2023 01:21
requirements/edx/base.txt Outdated Show resolved Hide resolved
@ChrisChV ChrisChV changed the title feat: New link on studio home to Taxonomy list and flag added feat: New link on studio home to Taxonomy list and flag added [FC-0036] Oct 13, 2023
@ChrisChV ChrisChV force-pushed the chris/FAL-3522-taxonomy-list-page branch 2 times, most recently from 9fede5d to 935d42f Compare October 13, 2023 15:53
@bradenmacdonald bradenmacdonald added the FC Relates to an Axim Funded Contribution project label Oct 13, 2023
@ChrisChV ChrisChV force-pushed the chris/FAL-3522-taxonomy-list-page branch from 91c3f41 to b16c733 Compare October 13, 2023 21:08
@ChrisChV ChrisChV force-pushed the chris/FAL-3522-taxonomy-list-page branch 2 times, most recently from 091dd8e to 41f8358 Compare October 16, 2023 13:57
@ChrisChV ChrisChV force-pushed the chris/FAL-3522-taxonomy-list-page branch from 41f8358 to 731722b Compare October 16, 2023 14:23
Copy link
Contributor

@rpenido rpenido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ChrisChV ! Good work here!

  • I read through the code
  • I followed the test instructions and ran the code locally

Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! Just to confirm, it's safe to merge this now even with old versions of the MFE that don't yet have the new taxonomies list page, right? Because everything is behind a waffle flag?

You'll need to merge master into this branch or rebase, then I can merge tomorrow.

@bradenmacdonald bradenmacdonald merged commit 1d58bd1 into openedx:master Oct 19, 2023
61 checks passed
@bradenmacdonald bradenmacdonald deleted the chris/FAL-3522-taxonomy-list-page branch October 19, 2023 17:19
@openedx-webhooks
Copy link

@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants