Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Changes to build Taxonomy List page [FC-0036] #98

Merged
merged 1 commit into from
Oct 13, 2023
Merged

feat: Changes to build Taxonomy List page [FC-0036] #98

merged 1 commit into from
Oct 13, 2023

Conversation

ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Oct 12, 2023 •
edited
Loading

Changes added:

  • Authentication classes added to tagging API views. This is so that calls from the MFE are correctly authenticated
  • Cast taxonomies before serialize in TaxonomySerializer
  • Test updated

Testing instructions

After merge

  • Bump a version

Internal ticket: FAL-3522
Github issue: openedx/modular-learning#104

@ChrisChV
feat: Changes to build Taxonomy List page
f637a7b 
* Authentication classes added to tagging API views
* Cast taxonomies before serialize in TaxonomySerializer
* Test updated
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 12, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

This was referenced Oct 13, 2023
Merged
Merged
@ChrisChV ChrisChV changed the title feat: Changes to build Taxonomy List page feat: Changes to build Taxonomy List page [FC-0036] Oct 13, 2023
rpenido
rpenido approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@rpenido rpenido left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have nothing to add.
Good work here @ChrisChV!

  • I read through the code
  • I checkout the branch and run the tests

We should just track the PRs merging order to bump the version.

@bradenmacdonald Could you take a look here as CC reviewer?

@bradenmacdonald bradenmacdonald merged commit d66d629 into openedx:main Oct 13, 2023
6 checks passed
@openedx-webhooks
Copy link

@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

bradenmacdonald
bradenmacdonald reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Approved 👍🏻

@bradenmacdonald bradenmacdonald deleted the chris/FAL-3522-taxonomy-list-page branch October 13, 2023 16:44
@bradenmacdonald bradenmacdonald added the FC Relates to an Axim Funded Contribution project label Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradenmacdonald bradenmacdonald bradenmacdonald left review comments

@rpenido rpenido rpenido approved these changes

Assignees
No one assigned
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChrisChV @openedx-webhooks @rpenido @bradenmacdonald