-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow adding tags to AndroidManifest.xml from project.xml. #1814
base: 8.3.0-Dev
Are you sure you want to change the base?
Conversation
Also, there's no need for `Reflect.hasField()`. We know it has the field, because we're iterating over `Reflect.fields()`.
For instance, `<config:android><manifest><uses-permission android:name="xyz" /></manifest></config:android>` will copy the `uses-permission` tag directly into the manifest. This allows you to specify attributes like `android:maxSdkVersion` that aren't normally available.
Oh yeah, and I streamlined |
I believe the |
Even sdl doesn't use them anymore. |
The documentation doesn't mention them being deprecated, and some of their guides tell you to use build.gradle while others point you to the manifest. I figure we might as well keep them in both places for now, until Google gets their documentation sorted out. |
For instance, if you need to use an obscure tag like
<uses-permission-sdk-23 />
, this change will let you enter it into<config:android />
rather than having to make a template.The nesting shown here is all required, and it tells Lime where to put this custom tag. In this case, it will go inside the
<manifest />
tag.<application />
and<activity />
are also available, and work similarly.Resolves #1812.