Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow adding tags to AndroidManifest.xml from project.xml. #1814

Open
wants to merge 9 commits into
base: 8.3.0-Dev
Choose a base branch
from
Open

Allow adding tags to AndroidManifest.xml from project.xml. #1814

wants to merge 9 commits into from

Commits on Jul 9, 2024

  1. Reduce indentation in ConfigData.

    @player-03
    player-03 committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    5ae6a05 View commit details
    Browse the repository at this point in the history

  2. Use more specific return type for getKeyValueArray().

    @player-03
    player-03 committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    eb86177 View commit details
    Browse the repository at this point in the history

  3. Reserve "config:" prefix when parsing config data.

    @player-03
    player-03 committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    d0bbdf6 View commit details
    Browse the repository at this point in the history

  4. Use new reserved prefix to avoid collisions.

    @player-03
    player-03 committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    62b9cc5 View commit details
    Browse the repository at this point in the history

  5. ConfigData: use stored values instead of looking them up repeatedly. 

    Also, there's no need for `Reflect.hasField()`. We know it has the field, because we're iterating over `Reflect.fields()`.
    @player-03
    player-03 committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    37bb081 View commit details
    Browse the repository at this point in the history

  6. Fix extraneous null values in ConfigData arrays.

    @player-03
    player-03 committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    2df5a11 View commit details
    Browse the repository at this point in the history

  7. Simplify control flow.

    @player-03
    player-03 committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    d65f28c View commit details
    Browse the repository at this point in the history

  8. Allow adding tags to AndroidManifest.xml from project.xml. 

    For instance, `<config:android><manifest><uses-permission android:name="xyz" /></manifest></config:android>` will copy the `uses-permission` tag directly into the manifest. This allows you to specify attributes like `android:maxSdkVersion` that aren't normally available.
    @player-03
    player-03 committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    221bb3d View commit details
    Browse the repository at this point in the history

  9. Fix Std.isOfType() being used in old Haxe versions.

    @player-03
    player-03 committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    5fd7060 View commit details
    Browse the repository at this point in the history