Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: Add/update translations #8930

Merged
merged 7 commits into from
Jan 22, 2024

Conversation

ArturLange
Copy link
Contributor

@ArturLange ArturLange commented Aug 31, 2023

What

Added new translations, fixed and updated old ones

Part of

@ArturLange ArturLange requested a review from a team as a code owner August 31, 2023 15:00
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🥗 Ingredients 🧪 additives 🥜 Allergens categories labels 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis labels Aug 31, 2023
@teolemon teolemon changed the title Add/update translations Add/update taxonomy and settings translations Aug 31, 2023
@teolemon teolemon added the 🇵🇱 Polish https://pl.openfoodfacts.org/ label Aug 31, 2023
@ArturLange ArturLange changed the title Add/update taxonomy and settings translations taxonomy: Add/update translations Aug 31, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9db5cd4) 49.44% compared to head (6dec95b) 44.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8930      +/-   ##
==========================================
- Coverage   49.44%   44.19%   -5.26%     
==========================================
  Files          67       65       -2     
  Lines       20644    20557      -87     
  Branches     4978     4966      -12     
==========================================
- Hits        10208     9085    -1123     
- Misses       9139    10293    +1154     
+ Partials     1297     1179     -118     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArturLange
Copy link
Contributor Author

@stephanegigandet Should be ready now 🙂

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alexgarel
Copy link
Member

I will update test result.

@alexgarel alexgarel enabled auto-merge (squash) January 22, 2024 15:27
Copy link

sonarcloud bot commented Jan 22, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alexgarel alexgarel merged commit 391b2fc into openfoodfacts:main Jan 22, 2024
12 checks passed
@alexgarel
Copy link
Member

👏 @ArturLange, thank you so much.

I will add you in the team so you can start your PR directly from this project (no need of a fork)

john-gom pushed a commit that referenced this pull request May 24, 2024
* taxonomy: add/fix polish ingredients
---------

Co-authored-by: Alex Garel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧪 additives 🥜 Allergens categories 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis ingredients analysis 🥗 Ingredients 🥗 Ingredients labels 💥 Merge Conflicts 💥 Merge Conflicts 🇵🇱 Polish https://pl.openfoodfacts.org/ 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants