chore: add minor changes to sample form submission api #7442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m0nggh
commented
Jun 26, 2024
KenLSM
approved these changes
Jun 26, 2024
2 tasks
m0nggh
added a commit
to opengovsg/plumber
that referenced
this pull request
Jul 8, 2024
**NOTE**: the short form for date field is fixed with a formsg [PR](opengovsg/FormSG#7442) instead ## Problem Right now, formsg sample form submission randomises the checkbox options which is not the best experience for users since they may want to use every option. ## Solution Formsg wanted the idea of randomising the options since it is a sample submission so I have forcefully included all checkbox options (including others option) on our end when we return the mock data. ## Tests - [x] Mock data with checkbox will give all options regardless of whether optional field or not - [x] Normal test data with a form submission still returns as intended
g-tejas
pushed a commit
that referenced
this pull request
Jul 18, 2024
* add minor changes to sample form submission api * revert checkbox field to randomising options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Data from the sample form submission API are not in the correct format.
fieldOptionsto allow users to use every option possibleshortformatSolution
shortBreaking Changes