build: release v6.131.0 #7459
Merged
build: release v6.131.0 #7459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recation_warnings fix: silence aws-sdk deprecation warnings
* add minor changes to sample form submission api * revert checkbox field to randomising options
…e-partner-support-contact chore: replace outdated esrv id link
* feat(admin-form): add frontend nric mask toggle to singpass auth settings * fix(admin-form): fix spacing and change units from px to rem * feat(admin-form): create isNricMaskingEnabled field in database when form is created * feat(admin-form): enable fetching and updating isNricMaskingEnabled field in backend routes * feat(admin-form): connect frontend component with server api routes * fix(admin-form): make code terser, remove unused params, fix nullish-coalesce operator usage * fix(admin-page): fix flickering bug * feat(duplicate-api): implement duplication of isNricMaskEnabled field * feat(public-form): prevent nric from reaching frontend if masked * feat(nric-mask): apply masking when submitting forms * feat(nric-mask): update frontend template to reflect masking toggle changes * fix(index.html): checkout to develop branch * fix: remove console.log * fix(toggle-component): replace nullish coalesce with ternary operator * chore(public-form-controller): remove masking when fetching public form at backend * fix: refactor email-submission-controller to mask at single location * fix: clean up nric-mask util function and unused imports * fix: update field with evaluated map value * feat: add nric masking to the frontend public form provider * feat: remove tooltip and labelComponentRight from Toggle to match design * feat: update settings auth page to reflect design master * feat: add err message * feat: change px to rem * feat: disable independently for nric masking and auth toggle * fix: change MyInfo to Myinfo in description message * fix: update form model test suite to expect new isNricMaskEnabled field * feat: add tests for nric mask util and masking for email submission * feat: add test for isNricMaskDisabled for email submission * feat: add tests for storage mode submission masking * fix: fix bug with submission not being able to save authType and defaulting to nil * feat: add stories for updated settings auth page * feat: update playwright test helper to support new auth setting flow * fix: fix review comments and run frontend lint fix * fix: fix based on chromatic review * fix: fix review comments * feat: add testing for getDuplicateParams to ensure that nricmask is correctly duplicated * refactor: extract skeleton component out to own file --------- Co-authored-by: Ken <[email protected]>
build: merge release v6.130.0 to develop
…7452) Bumps [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) from 4.17.5 to 4.17.6. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash) --- updated-dependencies: - dependency-name: "@types/lodash" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
build: merge release v6.130.1 to develop
…_hook_status_msg fix: update husky commit hook status msg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
#7458#7455#7451#7447#7388#7438#7442#7445b54927810b037dDependencies
Dev-Dependencies
#7452Tests
feat(admin-form): support nric masking
#7388@g-tejas
Test email mode nric should be masked when nric mask toggle is on:
Test storage mode nric should be masked when nric mask toggle is on + myinfo fields are not masked despite nric masking enabled + settings auth options are correctly disabled/enabled based on form state:
chore: replace outdated esrv id link
#7438helper text displays message as intended
@KenLSM