Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: silence aws-sdk deprecation warnings #7445

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

g-tejas
Copy link
Contributor

@g-tejas g-tejas commented Jun 26, 2024

Problem

The aws-sdk v2 for Javascript is deprecated end of next year but we get the error message on every single test ran, which gets very very cluttered and reduces the noise to signal ratio. It's also painful to sift through the messages to see what the actual error was with thousands of these messages.

This PR silences them during the workflow runs

Screenshot 2024-06-26 at 2.21.00 PM.png

Breaking Changes

  • No - this PR is backwards compatible

New environment variables:

  • AWS_SDK_JS_SUPPRESS_MAINTENANCE_MODE_MESSAGE : Silences the aws-sdk deprecation warnings

Copy link
Contributor Author

g-tejas commented Jun 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @g-tejas and the rest of your teammates on Graphite Graphite

@g-tejas g-tejas marked this pull request as ready for review June 26, 2024 06:21
@g-tejas g-tejas requested a review from KenLSM June 26, 2024 06:21
Copy link
Contributor

@KenLSM KenLSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@g-tejas g-tejas merged commit 9e51fa3 into develop Jun 26, 2024
25 checks passed
@g-tejas g-tejas deleted the 06-26-fix_silence_aws-sdk_deprecation_warnings branch June 26, 2024 06:53
@KenLSM KenLSM mentioned this pull request Jun 30, 2024
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants