(chore) O3-4011 - refactor patient banner to have patient identifiers… #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… component be reuseable
chibongho
requested review from
mseaton,
brandones,
mogoodrich,
denniskigen and
ibacher
|
Size Change: -141 kB (-2.4%) Total Size: 5.72 MB
ℹ️ View Unchanged
|
3 tasks
|
@chibongho can we have a screenshot, preferrably in the main patient banner, as I think this functionality extends beyond the Ward App? |
mogoodrich
approved these changes
Sep 30, 2024
No UI changes in this PR. but there will be in upcoming ones. Specifically, the patient identifier still gets incorrectly shown with the label (and not the number) in a tag: Desired behavior: the tag should enclose both the label and the identifier number, but only when multiple ones are present. The tag should be applied to the preferred identifier in that case. Mockup: link: https://app.zeplin.io/project/60d59321e8100b0324762e05/screen/66d83967b50d0e2f15927f84 |
|
Didn't get round to having a look at this, sorry. Thanks for getting it off the mark, @chibongho! |
Samstar10
pushed a commit
to Samstar10/openmrs-esm-core
that referenced
this pull request
Oct 29, 2024
… component be reuseable (openmrs#1159)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… component be reuseable
Requirements
feat,fix, orchore, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
This is motivated from a discussion on how the patient identifiers should show in the patient card in the ward app:
The above was said in regards to the patient banner, but should also apply to the ward patient card. This PR refactors the Patient Identifiers as a separate re-useable component, so we can reuse the same logic and configurations for patient banner and have them applied in the ward patient card (and elsewhere).
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-4011
Other
patient-charttoesm-styleguidea while ago, but there are some remnants of theexcludePatientIdentifierCodeTypesconfig value still present inpatient-chart, mostly used when the patient chart needs to display the patient identifiers outside of the patient banner. This change should help to with completely removing theexcludePatientIdentifierCodeTypesfrom the patient-chart.