add tests for fetch_releases pulling test images from quay.io
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XXL
steveej
force-pushed
the
test-fetch-releases-against-quay
branch
6 times, most recently
from
a594e53 to
0f7a1c3
Compare
steveej
force-pushed
the
test-fetch-releases-against-quay
branch
from
0f7a1c3 to
9072030
Compare
openshift-ci-robot
added
size/L
steveej
force-pushed
the
test-fetch-releases-against-quay
branch
3 times, most recently
from
9495851 to
471a2c7
Compare
|
@steveej: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
riuvshin
reviewed
Dec 3, 2018
steveej
force-pushed
the
test-fetch-releases-against-quay
branch
from
471a2c7 to
7cae2fb
Compare
steveej
changed the title
fetch_releases pulling test images from quay.iofetch_releases pulling test images from quay.io
openshift-ci-robot
added
the
do-not-merge/work-in-progress
steveej
force-pushed
the
test-fetch-releases-against-quay
branch
from
7cae2fb to
3b8e102
Compare
steveej
force-pushed
the
test-fetch-releases-against-quay
branch
from
3b8e102 to
d120eb8
Compare
steveej
changed the title
fetch_releases pulling test images from quay.iofetch_releases pulling test images from quay.io
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
steveej
force-pushed
the
test-fetch-releases-against-quay
branch
6 times, most recently
from
75447bc to
0e4b52a
Compare
I'm having trouble reviewing this without an overview. There seems to be a bunch of unrelated things in this PR, which leads me to believe that I don't understand how this all fits together. |
openshift-ci-robot
added
size/XL
|
/retest |
steveej
force-pushed
the
test-fetch-releases-against-quay
branch
from
ad577b1 to
9a3fbee
Compare
openshift-ci-robot
added
size/L
steveej
changed the title
fetch_releases pulling test images from quay.iofetch_releases pulling test images from quay.io
steveej
force-pushed
the
test-fetch-releases-against-quay
branch
6 times, most recently
from
6988073 to
5b3abbb
Compare
Add a set of integration tests which use manually set up images on the redhat quay.io organization. Since running against the production quay instance isn't ideal these tests are feature gated for now.
This paves the way for more flexible cargo test handling by allowing to pass explicit package targets and custom flags.
steveej
force-pushed
the
test-fetch-releases-against-quay
branch
from
5b3abbb to
31d0856
Compare
|
Yay the prow test is green 🙌 |
crawford
approved these changes
Jan 7, 2019
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, steveeJ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #8. Depends on #4.