reduces stripped JRE to what zipkin needs. #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, we added extra modules that are only used by our demo images. This turns out a fool's errand as recent Elasticsearch needs even more than before (e.g. kerberos stuff). Instead, we will switch the image to only pick what's required in the zipkin builds. Ancillary images can use the full dist. Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
force-pushed
the
less-strip
branch
from
03370f3 to
e499edc
Compare
anuraaga
approved these changes
Dec 15, 2023
|
thanks for the look! |
codefromthecrypt
added a commit
that referenced
this pull request
Dec 15, 2023
Before, we added extra modules that are only used by our demo images. This turns out a fool's errand as recent Elasticsearch needs even more than before (e.g. kerberos stuff). Instead, we will switch the image to only pick what's required in the zipkin builds. Ancillary images can use the full dist. Signed-off-by: Adrian Cole <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we added extra modules that are only used by our demo images. This turns out a fool's errand as recent Elasticsearch needs even more than before (e.g. kerberos stuff). Instead, we will switch the image to only pick what's required in the zipkin builds. Ancillary images can use the full dist.