license: removes copyright year and uses SPDX ID #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a small project, we have to conserve resources and not sign up for work that isn't required. I've recently realized many commerical and/or CNCF projects both use SPDX IDs and also don't bother with copyright year. If their legal team is ok with this, surely a volunteer team without access to one, should be, too! Doing so accomplishes the following: * significantly increases readability of files, particularly small ones * removes beginning of year maintenance, which cause a lot of FUD last year. IIRC some deployment failed and hours were spent in spite of docs. * eliminates the need to do a full source check out, just to satisfy the license plugin. This means we can use actions/checkout defaults. Same as openzipkin/zipkin-reporter-java#257 Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
changed the title
Signed-off-by: Adrian Cole <[email protected]>
| @@ -19,7 +19,6 @@ jobs: | |||
| # Prevent use of implicit GitHub Actions read-only token GITHUB_TOKEN. We don't deploy on | |||
| # the tag MAJOR.MINOR.PATCH event, but we still need to deploy the maven-release-plugin master commit. | |||
| token: ${{ secrets.GH_TOKEN }} | |||
| fetch-depth: 1 # only need the HEAD commit as license check isn't run | |||
| @@ -22,7 +22,6 @@ jobs: | |||
| # Prevent use of implicit GitHub Actions read-only token GITHUB_TOKEN. | |||
| # We push Javadocs to the gh-pages branch on commit. | |||
| token: ${{ secrets.GH_TOKEN }} | |||
| fetch-depth: 0 # allow build-bin/idl_to_gh_pages to get the full history | |||
There was a problem hiding this comment.
copy/pasta for zipkin and not used here
| @@ -15,8 +15,6 @@ jobs: | |||
| steps: | |||
| - name: Checkout Repository | |||
| uses: actions/checkout@v4 | |||
| with: | |||
| fetch-depth: 1 # only needed to get the sha label | |||
| @@ -21,8 +21,6 @@ jobs: | |||
| steps: | |||
| - name: Checkout Repository | |||
| uses: actions/checkout@v4 | |||
| with: | |||
| fetch-depth: 0 # full git history for license check | |||
There was a problem hiding this comment.
no longer needed
| @@ -58,8 +56,6 @@ jobs: | |||
| steps: | |||
| - name: Checkout Repository | |||
| uses: actions/checkout@v4 | |||
| with: | |||
| fetch-depth: 1 # -Dlicense.skip=true, so we don't need a full clone | |||
| --- | ||
| name: readme_test | ||
| name: test_readme |
There was a problem hiding this comment.
to match zipkin
| runs-on: ubuntu-22.04 # newest available distribution, aka jellyfish | ||
| steps: | ||
| - name: Checkout Repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 1 |
Signed-off-by: Adrian Cole <[email protected]>
reta
approved these changes
Apr 14, 2024
|
thanks for the look @reta! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a small project, we have to conserve resources and not sign up for work that isn't required. I've recently realized many commerical and/or CNCF projects both use SPDX IDs and also don't bother with copyright year. If their legal team is ok with this, surely a volunteer team without access to one, should be, too! Doing so accomplishes the following:
Same as openzipkin/zipkin-reporter-java#257