-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
license: removes copyright year and uses SPDX ID #224
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,7 +22,6 @@ jobs: | |
# Prevent use of implicit GitHub Actions read-only token GITHUB_TOKEN. | ||
# We push Javadocs to the gh-pages branch on commit. | ||
token: ${{ secrets.GH_TOKEN }} | ||
fetch-depth: 0 # allow build-bin/idl_to_gh_pages to get the full history | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. copy/pasta for zipkin and not used here |
||
- name: Setup java | ||
uses: actions/setup-java@v4 | ||
with: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,8 +15,6 @@ jobs: | |
steps: | ||
- name: Checkout Repository | ||
uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 1 # only needed to get the sha label | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. default is 1 |
||
# Don't attempt to cache Docker. Sensitive information can be stolen | ||
# via forks, and login session ends up in ~/.docker. This is ok because | ||
# we publish DOCKER_PARENT_IMAGE to ghcr.io, hence local to the runner. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,8 +21,6 @@ jobs: | |
steps: | ||
- name: Checkout Repository | ||
uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 0 # full git history for license check | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no longer needed |
||
- name: Cache local Maven repository | ||
uses: actions/cache@v3 | ||
with: | ||
|
@@ -58,8 +56,6 @@ jobs: | |
steps: | ||
- name: Checkout Repository | ||
uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 1 # -Dlicense.skip=true, so we don't need a full clone | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. default is 1 |
||
- name: Cache local Maven repository | ||
uses: actions/cache@v3 | ||
with: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
# yamllint --format github .github/workflows/readme_test.yml | ||
# yamllint --format github .github/workflows/test_readme.yml | ||
--- | ||
name: readme_test | ||
name: test_readme | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. to match zipkin |
||
# These test build commands mentioned in various README.md files. | ||
# | ||
|
@@ -13,13 +13,11 @@ on: | |
paths-ignore: '**/*.md' | ||
|
||
jobs: | ||
readme_test: | ||
zipkin-dependencies: | ||
runs-on: ubuntu-22.04 # newest available distribution, aka jellyfish | ||
steps: | ||
- name: Checkout Repository | ||
uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 1 | ||
- name: Setup java | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. default is 1 |
||
uses: actions/setup-java@v4 | ||
with: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default is 1