Improve Library Versions Dependabot #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnestoro
force-pushed
the
dnestoro/CreateLibraryVersionsDependabot
branch
from
52ab426 to
87027fa
Compare
olpaw
reviewed
Nov 13, 2024
| ALL_COMMENTS=$(gh issue view "${{ needs.get-all-libraries.outputs.issue }}" --comments) | ||
|
|
||
| FORMATTED_BODY=$(./gradlew -q extractLibrariesGroupsFromGithubComments --comments="$ALL_COMMENTS") | ||
| gh issue create --title "List unsupported libraries versions" --body "$FORMATTED_BODY" |
There was a problem hiding this comment.
Will this create new a new issue every time the action runs or will the issue update if it already exists?
There was a problem hiding this comment.
It will create an issue every time we run the action
There was a problem hiding this comment.
We can't do that. We need to keep the updated one. That is why I proposed an issue per library that is updated over slack.
olpaw
reviewed
Nov 13, 2024
tests/tck-build-logic/src/main/groovy/org.graalvm.internal.tck-harness.gradle
Outdated
Show resolved
Hide resolved
|
I'm afraid I won't have time to review this PR this week. |
olpaw
reviewed
Nov 13, 2024
...ogic/src/main/groovy/org/graalvm/internal/tck/harness/tasks/GroupUnsupportedLibraries.groovy
Outdated
Show resolved
Hide resolved
olpaw
reviewed
Nov 13, 2024
...ogic/src/main/groovy/org/graalvm/internal/tck/harness/tasks/GroupUnsupportedLibraries.groovy
Outdated
Show resolved
Hide resolved
olpaw
reviewed
Nov 13, 2024
...ogic/src/main/groovy/org/graalvm/internal/tck/harness/tasks/GroupUnsupportedLibraries.groovy
Outdated
Show resolved
Hide resolved
olpaw
reviewed
Nov 13, 2024
...ogic/src/main/groovy/org/graalvm/internal/tck/harness/tasks/GroupUnsupportedLibraries.groovy
Outdated
Show resolved
Hide resolved
olpaw
reviewed
Nov 13, 2024
...ogic/src/main/groovy/org/graalvm/internal/tck/harness/tasks/GroupUnsupportedLibraries.groovy
Outdated
Show resolved
Hide resolved
olpaw
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It improves issue for unsupported libraries by grouping different versions of the same library.
Feature provided in this PR collects all comments from the issue that contains unsupported libraries (that jobs from workflows matrix added) and groups them by library name.
The final issue should look like this:
