Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Library Versions Dependabot #565

Merged
merged 2 commits into from
Nov 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/check-new-library-versions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,25 @@ jobs:
steps:
- name: "☁️ Checkout repository"
uses: actions/checkout@v4
- name: "🔧 Setup java"
uses: actions/setup-java@v4
with:
distribution: 'oracle'
java-version: '21'
- name: "✏️ PR for supported versions"
run: |
git config --local user.email "[email protected]"
git config --local user.name "Github Actions"
git fetch origin check-new-library-versions/$(date '+%Y-%m-%d')
git checkout check-new-library-versions/$(date '+%Y-%m-%d')
gh pr create --title "Update supported library versions" --body "This pull request updates supported versions of the existing libraries in the repo"
- name: "✏️ Edit issue for unsupported versions"
run: |
git config --local user.email "[email protected]"
git config --local user.name "Github Actions"
ALL_COMMENTS=$(gh issue view "${{ needs.get-all-libraries.outputs.issue }}" --comments)

FORMATTED_BODY=$(./gradlew -q extractLibrariesGroupsFromGithubComments --comments="$ALL_COMMENTS")
gh issue create --title "List unsupported libraries versions" --body "$FORMATTED_BODY"
Copy link
Member

@olpaw olpaw Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this create new a new issue every time the action runs or will the issue update if it already exists?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will create an issue every time we run the action

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't do that. We need to keep the updated one. That is why I proposed an issue per library that is updated over slack.


gh issue close "${{ needs.get-all-libraries.outputs.issue }}"
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import org.graalvm.internal.tck.GrypeTask
import org.graalvm.internal.tck.TestedVersionUpdaterTask
import org.graalvm.internal.tck.harness.tasks.CheckstyleInvocationTask
import org.graalvm.internal.tck.harness.tasks.FetchExistingLibrariesWithNewerVersionsTask
import org.graalvm.internal.tck.harness.tasks.GroupUnsupportedLibraries
import org.graalvm.internal.tck.harness.tasks.TestInvocationTask


Expand Down Expand Up @@ -170,6 +171,11 @@ tasks.register("fetchExistingLibrariesWithNewerVersions", FetchExistingLibraries
task.setAllLibraryCoordinates(matchingCoordinates)
}

tasks.register("extractLibrariesGroupsFromGithubComments", GroupUnsupportedLibraries.class) { task ->
task.setGroup(METADATA_GROUP)
task.setDescription("Extracts groups of libraries from github comments provided in a form of string.")
}

// java tasks
tasks.register("checkAllowedDockerImages", GrypeTask.class) { task ->
task.setDescription("Returns list of allowed docker images")
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
package org.graalvm.internal.tck.harness.tasks

import org.gradle.api.DefaultTask
import org.gradle.api.provider.Property
import org.gradle.api.tasks.Input
import org.gradle.api.tasks.TaskAction
import org.gradle.api.tasks.options.Option
import org.gradle.util.internal.VersionNumber

import java.util.regex.Matcher
import java.util.regex.Pattern

abstract class GroupUnsupportedLibraries extends DefaultTask {

@Input
@Option(option = "comments", description = "Provides github comments for library grouping as string.")
abstract Property<String> getGithubComments()

@TaskAction
void action() {
def pattern = Pattern.compile("--[\n ](.*?)[\n ]--")
def matcher = pattern.matcher(getGithubComments().get())

def libraryGroups = new HashMap<String, List<String>>()
while (matcher.find()) {
def coordinates = matcher.group(1)
def coordinatesPart = coordinates.split(":")
def artifactKey = coordinatesPart[0] + ":" + coordinatesPart[1]
def version = coordinatesPart[2]

if (libraryGroups.get(artifactKey) == null) {
libraryGroups.put(artifactKey, new ArrayList<String>())
}

libraryGroups.get(artifactKey).add(version)
libraryGroups.get(artifactKey).sort(Comparator.comparing(VersionNumber::parse))
}

print generateGroupedComment(libraryGroups)
}

private static String generateGroupedComment(Map<String, List<String>> groups) {
def sb = new StringBuilder("List of all unsupported libraries:\n")

for (String library : groups.keySet()) {
sb.append("- ").append(library).append(":\n")

for (String version : groups.get(library)) {
sb.append("\t").append("- ").append(version).append("\n")
}

sb.append("\n")
}

return sb.toString()
}

}
Loading