Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(zimbra): migrate to @ovhcloud/ods-components v18.3.1 #13633

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(zimbra): migrate to @ovhcloud/ods-components v18.3.1 #13633

wants to merge 1 commit into from

Conversation

stif59100
Copy link
Contributor

@stif59100 stif59100 commented Oct 17, 2024 •
edited by tristanwagner
Loading

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-15662
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@github-actions github-actions bot added has conflicts Has conflicts to resolve before merging universe-web-cloud translation required dependencies Pull requests that update a dependency file feature New feature labels Oct 17, 2024
Base automatically changed from feat/zimbra-ga to release/hosting-collaboration-w43 October 17, 2024 14:53
@stif59100 stif59100 force-pushed the feat/MANAGER-15662 branch 2 times, most recently from 2c7065a to cf36844 Compare October 18, 2024 08:48
Base automatically changed from release/hosting-collaboration-w43 to master October 21, 2024 08:15
@tristanwagner tristanwagner force-pushed the feat/MANAGER-15662 branch 4 times, most recently from fa0b0a0 to 76ea4a0 Compare October 24, 2024 14:49
@tristanwagner tristanwagner changed the title Feat/manager 15662 feat(zimbra): migrate to @ovhcloud/ods-components v18.2.0 Oct 24, 2024
@tristanwagner
Copy link
Contributor

tristanwagner commented Oct 24, 2024 •
edited
Loading

Known issues:

  • Breadcrumb has a bug where some items are not clickable
  • Some tooltips are having a weird behavior
  • Select that are disabled while fetching option data get stuck in disabled state
  • ManagerButton IAM seems to have an issue ?
  • Modals have a fixed max-height: 50vh;
  • ActionMenu buttons are not taking full width of the popover
  • bundle size increased => total bundle size seems to have increased by ~1mb

@tristanwagner tristanwagner force-pushed the feat/MANAGER-15662 branch 9 times, most recently from 08b933e to 0897832 Compare October 29, 2024 14:38
@tristanwagner tristanwagner force-pushed the feat/MANAGER-15662 branch 5 times, most recently from b616bf5 to a005ca9 Compare November 21, 2024 11:34
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Nov 21, 2024
@github-actions github-actions bot removed the common label Nov 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

yarn.lock changes

Click to toggle table visibility
Name Status Previous Current
@ovhcloud/ods-components UPDATED 18.3.0 18.3.1
@ovhcloud/ods-themes UPDATED 18.3.0 18.3.1

@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Nov 22, 2024
@tristanwagner tristanwagner force-pushed the feat/MANAGER-15662 branch 3 times, most recently from 85e0074 to 46df9b5 Compare November 22, 2024 10:55
tristanwagner
tristanwagner requested changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@tristanwagner tristanwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first 2 commits should be dropped when they will be merged into master

@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Nov 25, 2024
@github-actions github-actions bot removed translation required has conflicts Has conflicts to resolve before merging labels Nov 25, 2024
tristanwagner
tristanwagner previously approved these changes Nov 25, 2024
View reviewed changes
@tristanwagner tristanwagner changed the title feat(zimbra): migrate to @ovhcloud/ods-components v18.3.0 feat(zimbra): migrate to @ovhcloud/ods-components v18.3.1 Nov 25, 2024
tristanwagner
tristanwagner previously approved these changes Nov 25, 2024
View reviewed changes
@tristanwagner
feat(zimbra): bump @ovhcloud/ods-components v18.3
fa696d5 
ref: MANAGER-15662

Signed-off-by: Tristan WAGNER <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 25, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.7% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghyenne ghyenne ghyenne left review comments

@tristanwagner tristanwagner tristanwagner left review comments

@antonymarion antonymarion antonymarion left review comments

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique is a code owner automatically assigned from ovh/team-manager-dev-angularjs

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file feature New feature quality check: ok universe-web-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stif59100 @tristanwagner @antonymarion @ghyenne