Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable openssl legacy #161

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Enable openssl legacy #161

merged 2 commits into from
Apr 18, 2023

Conversation

phil-davis
Copy link
Contributor

Ubuntu 22.04 has openssl v3. openssl v3 disables various legacy encryption methods. For the current oC10 encryption app, we need those legacy encryption methods to be available.

This PR provides an etc/ssl/opensssl.cnf that has the legacy encryption methods enabled.

Ref: owncloud/core#40745 tries to run core CI with Ubuntu 22.04 docker.
Related core issue owncloud/core#40071
Documentation about how production Ubuntu 22.04 systems enable the legacy encryption methods: https://doc.owncloud.com/server/10.12/admin_manual/installation/manual_installation/manual_installation_prerequisites.html#openssl-version

@phil-davis phil-davis requested a review from xoxys April 18, 2023 11:38
@phil-davis
Copy link
Contributor Author

@xoxys is this the way to achieve this? Or is there a different way it should be done?

@xoxys
Copy link
Contributor

xoxys commented Apr 18, 2023

IMO, we should not use Ubuntu 22 for anything related to oc10. We add more and more hacks and workarounds to get it working somehow (PHP, OpenSSL, etc.). Sticking to Ubuntu 20.04 as long as possible, especially for the production containers owncloud/server and owncloud/appliance I would not recommend the switch to Ubuntu 22.

However, if the legacy stuff is really required, yes I guess that's the way to go even if I have not tested/verified it.

@xoxys
Copy link
Contributor

xoxys commented Apr 18, 2023

Don't know the details, but is it really a good idea to tell people to use the legacy mode instead of fixing the code to support a modern OpenSSL version?

@phil-davis
Copy link
Contributor Author

We have theowncloud-ci/php container versions for Ubuntu 22.04 so it would be nice to apply the customisations that we know about. That way those container versions can be used to "easily" check the Ubuntu 22.04 + PHP 7.4 + ownCloud10 combination.

https://doc.owncloud.com/server/next/admin_manual/installation/system_requirements.html#officially-supported-environments lists Ubuntu 20.04 and 22.04 - so if 22.04 is not to be supported, that would need to be discussed.

Copy link
Contributor

@xoxys xoxys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me. But shouldn't the CI fail as expected as long as the encryption app is not fixed properly? The legacy mode might be a workaround for existing deployments, but it's still just a workaround and not a proper fix. However, don't want to block you, feel free to merge.

@xoxys
Copy link
Contributor

xoxys commented Apr 18, 2023

As there are no plans to fix it, using the legacy mode is the only way.

@phil-davis phil-davis merged commit 8c109b1 into master Apr 18, 2023
@phil-davis phil-davis deleted the enable-openssl-legacy branch April 18, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants