Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] PHP Ubuntu22.04 #40745

Closed
wants to merge 1 commit into from

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Apr 18, 2023

Description

WIP - This replaces #40123

Note: current master uses PHP 7.4 with Ubuntu 20.04 - see PR #40417
The owncloudci/php:7.4 docker image uses Ubuntu 20.04 as its base nowadays.

Related Issue

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis
Copy link
Contributor Author

phil-davis commented Apr 18, 2023

https://drone.owncloud.com/owncloud/core/38281/114/14
Something goes wrong with the acceptance test pipeline that uses encryption.
https://drone.owncloud.com/owncloud/core/38281/114/13 server log has entries like:

{"reqId":"Jde9kPeffXbnIisx404g","level":4,
"time":"2023-04-18T07:18:09+00:00",
"remoteAddr":"192.168.1.5",
"user":"admin",
"app":"webdav",
"method":"PUT",
"url":"\/remote.php\/webdav\/lorem.txt",
"message":"Exception: HTTP\/1.1 503 Encryption not ready: multikeyencryption failed error:0480006C:PEM routines::no start line: 
{\"Exception\":\"Sabre\\\\DAV\\\\Exception\\\\ServiceUnavailable\",\"Message\":\"Encryption not ready: multikeyencryption failed error:0480006C:PEM routines::no start line\",\"Code\":0,
\"Trace\":\"
#0 \\\/drone\\\/src\\\/apps\\\/dav\\\/lib\\\/Connector\\\/Sabre\\\/File.php(240): OCA\\\\DAV\\\\Connector\\\\Sabre\\\\File->convertToSabreException()\\n
#1 \\\/drone\\\/src\\\/apps\\\/dav\\\/lib\\\/Connector\\\/Sabre\\\/Directory.php(172): OCA\\\\DAV\\\\Connector\\\\Sabre\\\\File->put()\\n
#2 \\\/drone\\\/src\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(1098): OCA\\\\DAV\\\\Connector\\\\Sabre\\\\Directory->createFile()\\n
#3 \\\/drone\\\/src\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/CorePlugin.php(504): Sabre\\\\DAV\\\\Server->createFile()\\n
#4 \\\/drone\\\/src\\\/lib\\\/composer\\\/sabre\\\/event\\\/lib\\\/WildcardEmitterTrait.php(89): Sabre\\\\DAV\\\\CorePlugin->httpPut()\\n
#5 \\\/drone\\\/src\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(472): Sabre\\\\DAV\\\\Server->emit()\\n
#6 \\\/drone\\\/src\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(253): Sabre\\\\DAV\\\\Server->invokeMethod()\\n
#7 \\\/drone\\\/src\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(321): Sabre\\\\DAV\\\\Server->start()\\n
#8 \\\/drone\\\/src\\\/apps\\\/dav\\\/appinfo\\\/v1\\\/webdav.php(67): Sabre\\\\DAV\\\\Server->exec()\\n
#9 \\\/drone\\\/src\\\/remote.php(165): require_once('\\\/drone\\\/src\\\/apps...')\\n
#10 {main}\",\"File\":\"\\\/drone\\\/src\\\/apps\\\/dav\\\/lib\\\/Connector\\\/Sabre\\\/File.php\",\"Line\":725}"}

I suppose that there is something else to do to st up encryption properly - there was something documented about deprecated encryption algorithms in the encryption libraries with Ubuntu 22.04. We will need to enable the deprecated things in CI.

See issue #40071 for discussion and links to elsewhere.

Documented at https://doc.owncloud.com/server/10.12/admin_manual/installation/manual_installation/manual_installation_prerequisites.html#openssl-version

@phil-davis
Copy link
Contributor Author

owncloud-ci/php#161 enables legacy encryption methods in the Ubuntu 22.04 PHP docker image.

I will rerun CI...

@phil-davis phil-davis force-pushed the php-ubuntu22.04-202304 branch from 417f95b to 9a7e826 Compare April 18, 2023 15:51
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
Copy link
Contributor Author

Passes now - good.

@phil-davis
Copy link
Contributor Author

See #40747 for proposed pipelines to run with PHP 7.4 on Ubuntu 22.04

@phil-davis phil-davis closed this Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant