Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[a11y] 11.1.4.3 Contrast (minimum) #4429

Merged
merged 14 commits into from
Jul 3, 2024
Merged

[a11y] 11.1.4.3 Contrast (minimum) #4429

merged 14 commits into from
Jul 3, 2024

Conversation

Aitorbp
Copy link
Contributor

@Aitorbp Aitorbp commented Jun 25, 2024 •
edited by jesmrec
Loading

Related Issues

App:

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

#4429 (comment)

@Aitorbp Aitorbp linked an issue Jun 25, 2024 that may be closed by this pull request
[a11y] 11.1.4.3 Contrast (minimum) #4364
Closed
5 tasks
@Aitorbp Aitorbp force-pushed the feature/contrast_minimum_accesibility branch from 9ce4c53 to d7ad44f Compare June 25, 2024 12:59
@Aitorbp
Copy link
Contributor Author

Aitorbp commented Jul 1, 2024 •
edited by JuancaG05
Loading

Everything related to the toolbar will be done in this issue: #4365.

@Aitorbp Aitorbp force-pushed the feature/contrast_minimum_accesibility branch 3 times, most recently from 4af17c3 to 9d1a992 Compare July 1, 2024 12:55
@Aitorbp Aitorbp force-pushed the feature/contrast_minimum_accesibility branch from c654dbf to a67a1f1 Compare July 2, 2024 09:59
@Aitorbp Aitorbp requested a review from JuancaG05 July 2, 2024 10:16
@Aitorbp
Copy link
Contributor Author

Aitorbp commented Jul 2, 2024 •
edited
Loading

The list_item_lastmod_and_filesize_text color has been changed to meet minimum contrast requirements. Apart from the places that it says in the issue, it has also been changed in:

  • Log list (subtitle): Log size
  • Transfer list (subtitles and icons)
  • Subtitle bottom sheet file
  • Receive external files: The subtitle of the items when a folder is chosen to upload

In addition, the share_warning_text color has been modified to meet with minimum contrast requirements. This text color is visible in the warning of public links and the text color has also been changed in:

  • Files folder picker: You do not have permission to add content here! text
  • Choose upload folder: You do not have permission to add content here! text

FYI @jesmrec @JuancaG05

JuancaG05
JuancaG05 requested changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes required here @Aitorbp

owncloudApp/src/main/res/values/colors.xml Outdated Show resolved Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/files/filelist/FileListAdapter.kt Outdated Show resolved Hide resolved
owncloudApp/src/main/java/com/owncloud/android/ui/activity/DrawerActivity.kt Outdated Show resolved Hide resolved
owncloudApp/src/main/res/layout/share_file_layout.xml Outdated Show resolved Hide resolved
@Aitorbp
Copy link
Contributor Author

Aitorbp commented Jul 2, 2024 •
edited
Loading

The list_item_lastmod_and_filesize_text color have been changed for this hex value #707575 to meet with the requirements:

list_item_lastmod_and_filesize_text

Also we have created a new color share_warning_text (#525757) for public link warning description to meet the requirements:

share_warning_text

Contrast checked used: https://webaim.org/resources/contrastchecker/

@Aitorbp Aitorbp requested a review from JuancaG05 July 2, 2024 15:05
JuancaG05
JuancaG05 approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesmrec
Copy link
Collaborator

jesmrec commented Jul 3, 2024

QA checks:

date and size in list of files

Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅

drawer footer (quota)

Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅

land-drawer footer (quota)

Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅

list footer (#files & #folders)

Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅

shared file size

Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅

warning public link

Contrast: #525757 vs #E0E0E0 ➡️ 5.56 > 4.50 ✅

expiration date in public link

Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅

folder picker - target folder with no writing permissions

Contrast: #525757 vs #E0E0E0 ➡️ 5.56 > 4.50 ✅

folder picker - share from 3rd party app to folder with no writing permissions

Contrast: #525757 vs #E0E0E0 ➡️ 5.56 > 4.50 ✅

log size

Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅

upload list: status, size, date, account, space and target folder

Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅

bottom sheet: date and size

Contrast: #707575 vs #FFFFFF ➡️ 4.68 > 4.50 ✅

tested all views in portrait/landscape orientation.

Also, i took a look to the high contrast mode, which look is much better than before. Moving forward an accessible app step by step 💯

This is approved from my side.

@Aitorbp Aitorbp merged commit fab7a1e into master Jul 3, 2024
5 checks passed
@Aitorbp Aitorbp deleted the feature/contrast_minimum_accesibility branch July 3, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuancaG05 JuancaG05 JuancaG05 approved these changes

Assignees
No one assigned
Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[a11y] 11.1.4.3 Contrast (minimum)
3 participants
@Aitorbp @jesmrec @JuancaG05