-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[a11y] Keyboard navigation in security passcode view #4455
[a11y] Keyboard navigation in security passcode view #4455
Conversation
The toolbar is not accessible by the keyboard because of technical restriction. See this comment to more details. |
...oudApp/src/main/java/com/owncloud/android/presentation/security/passcode/PassCodeActivity.kt
Show resolved
Hide resolved
...oudApp/src/main/java/com/owncloud/android/presentation/security/passcode/PassCodeActivity.kt
Show resolved
Hide resolved
c8693bd
to
7d67070
Compare
Things i am missing here:
|
Now It should work.
Try again. With my external keyboard the ESC key is working. But I added something else. Let´s see.
No, It is not meeting the contrast requirements |
After last commit:
|
About contrast requirements: If we do the same test with the gray of the background, this would be the result: On the other hand, the contrast between the focused and unfocused state does not meet the recommended contrast ratio either (at least 3:1). For example, if we focus on the blue of the buttons: To give you an idea of what the final result would be in the application with the focus to black: |
Let's move the contrast thing to the global topic, then... this one is approved, at least for a first iteration. |
a2b7ea3
to
e3898c2
Compare
Related Issues
App: #4447
ReleaseNotesViewModel.kt
creating a newReleaseNote()
with String resources (if required)QA