Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RELEASE] 4.4.1 #4502

Merged
merged 12 commits into from
Oct 30, 2024
Merged

[RELEASE] 4.4.1 #4502

merged 12 commits into from
Oct 30, 2024

Conversation

joragua
Copy link
Collaborator

@joragua joragua commented Oct 23, 2024 •
edited
Loading

Related Issues

App:

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

This was linked to issues Oct 23, 2024
[BUG] File size becomes 0 after a local update #4495
Closed
[RELEASE] 4.4.1 #4501
Closed
@joragua joragua closed this Oct 23, 2024
@joragua joragua removed a link to an issue Oct 23, 2024
[RELEASE] 4.4.1 #4501
Closed
22 tasks
@joragua joragua linked an issue Oct 23, 2024 that may be closed by this pull request
[RELEASE] 4.4.1 #4501
Closed
22 tasks
@joragua joragua reopened this Oct 23, 2024
@joragua joragua requested a review from JuancaG05 October 24, 2024 06:36
jesmrec
jesmrec requested changes Oct 24, 2024
View reviewed changes
changelog/4.4.1_2024-10-28/4502 Outdated Show resolved Hide resolved
changelog/4.4.1_2024-10-28/4502 Outdated Show resolved Hide resolved
owncloudApp/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@joragua joragua marked this pull request as ready for review October 24, 2024 10:33
@joragua joragua requested a review from jesmrec October 24, 2024 10:41
JuancaG05
JuancaG05 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@joragua joragua force-pushed the release/4.4.1 branch 3 times, most recently from c8f67ee to b71d41d Compare October 24, 2024 12:15
@joragua joragua requested a review from JuancaG05 October 24, 2024 12:21
JuancaG05
JuancaG05 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@joragua joragua requested a review from JuancaG05 October 28, 2024 12:19
JuancaG05
JuancaG05 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jesmrec
Copy link
Collaborator

jesmrec commented Oct 29, 2024

Release v4.4.1 is approved

  • Approved commit: 4ef4cc200
  • Android Studio version: Android Studio Koala | 2024.1.1 Patch 2
  • Devices:
    • Pixel 2, Android 11
    • Xiaomi Redmi 13, Android 14
    • Galaxy Tab A8, Android 14

Ready to go! Great job, team! 💯

@joragua joragua merged commit e638d09 into master Oct 30, 2024
7 checks passed
@joragua joragua deleted the release/4.4.1 branch October 30, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuancaG05 JuancaG05 JuancaG05 approved these changes

@jesmrec jesmrec jesmrec approved these changes

Assignees
No one assigned
Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RELEASE] 4.4.1 [BUG] File size becomes 0 after a local update
3 participants
@joragua @jesmrec @JuancaG05