-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Adding new symfony events to replace old hooks #30268
Conversation
There is a followup for this PR in the app: owncloud/encryption#25 |
Codecov Report
@@ Coverage Diff @@
## master #30268 +/- ##
=============================================
- Coverage 61.54% 15.82% -45.73%
+ Complexity 18500 920 -17580
=============================================
Files 1090 51 -1039
Lines 61084 3356 -57728
=============================================
- Hits 37593 531 -37062
+ Misses 23491 2825 -20666
Continue to review full report at Codecov.
|
860cf9d
to
51dfdfd
Compare
e958729
to
2f4cf9c
Compare
1e60b73
to
db5df19
Compare
Adding new symfony events for the following: 1) setPassword 2) setPassphrase Signed-off-by: Sujith H <[email protected]>
db5df19
to
75893f8
Compare
please don't delete the old hooks, we want to stay compatible the event dispatcher events are an addition |
obsolete ? |
tech debt to be rescheduled |
As discussed in #35777 the master branch will from now on hold the ownCloud 10 codebase. This PR targetted ownCloud 11 which is postponed to a far distant future. Because of that I'm closing this PR and kindly ask you to re-submit this PR in a few days. Thanks a lot for your patience |
Adding new symfony events for the following:
Signed-off-by: Sujith H [email protected]
Description
There are more places where old hooks are being used. The intention of this PR is to hunt them down and replace with the symfony events.
Related Issue
Motivation and Context
Replace the old private hooks with the symfony events.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: