Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipOnOcV10.3 the tests scenarios added or adjusted for 10.4 #36624

Merged
merged 3 commits into from
Dec 23, 2019

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Dec 23, 2019

Description

Various test scenarios were added or adjusted for 10.4 features or fixes. Those test scenarios are not relevant to run against core 10.3 systems, so skip the scenarios for that.

PR #36573 - "include expiration option for user and group shares"
PR #36572 "Add share indicator on webUI"

  • the workflow/xpaths for tests to open the sharing details to adjust detailed permissions or enter an expiry date has changed.
  • the share indicator also provides some different share details in the display

PR #36613 - allow + sign in user names

  • the test scenarios will not work any more in 10.3

Related Issue

Motivation and Context

Get green CI when running tests in apps against old core 10.3 releases

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@codecov
Copy link

codecov bot commented Dec 23, 2019

Codecov Report

Merging #36624 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #36624   +/-   ##
=========================================
  Coverage     64.68%   64.68%           
  Complexity    19105    19105           
=========================================
  Files          1269     1269           
  Lines         74721    74721           
  Branches       1320     1320           
=========================================
  Hits          48333    48333           
  Misses        26000    26000           
  Partials        388      388
Flag Coverage Δ Complexity Δ
#javascript 54.12% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.85% <ø> (ø) 19105 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb062c4...72b6c30. Read the comment docs.

@phil-davis phil-davis merged commit 2dbba00 into master Dec 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the skipOnOcV10.3-20191223 branch December 23, 2019 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webUI acceptance test fails
3 participants