Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run core CLI acceptance tests in drone #179

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Feb 10, 2020

And reduce the number of parts that the core API tests are split into.
Because there is currently a limit of 1,000,000 bytes on the size of .drone.yml

Beacuse of issue owncloud/user_ldap#509

( user_ldap was already running some core CLI acceptance tests with both LDAP and encryption together, so be had better run core CLI acceptance tests with encryption here)

@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #179 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #179   +/-   ##
=========================================
  Coverage     71.94%   71.94%           
  Complexity      612      612           
=========================================
  Files            35       35           
  Lines          2299     2299           
=========================================
  Hits           1654     1654           
  Misses          645      645

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0093cd7...b115312. Read the comment docs.

And reduce the number of parts that the core API tests are split into.
Because there is currently a limit of 1,000,000 bytes on the size of .drone.yml
@phil-davis phil-davis force-pushed the cli-acceptance-tests-with-encryption branch from 0e033cf to b115312 Compare February 20, 2020 15:06
@phil-davis phil-davis marked this pull request as ready for review February 21, 2020 04:39
@phil-davis
Copy link
Contributor Author

This should pass now. The appropriate skipOnEncryption has been done in core, and issues raised for problems found, e.g. #181 #182

Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@individual-it individual-it merged commit 913303d into master Feb 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the cli-acceptance-tests-with-encryption branch February 21, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants