Use rawurldecode for allowing "+" in guests emails

[pako81]

Description

Use rawurldecode instead of urldecode for allowing + in guests emails since urldecode decodes also + symbol to a space character.

Related Issue

• Requires Allow "+" character in usernames core#36613

• Fixes https://github.com/owncloud/enterprise/issues/3712

• also fixes password change test fails with stable10 #332 (the test steps about changing password of a guest user work fine now, so they are enabled again, see the last commit)

Motivation and Context

Since urldecode decodes also + symbol to a space character it is not possible to create guest users having i.e. the following format [email protected], which is a perfectly fine format.

How Has This Been Tested?

Manually by sharing with guest users having the [email protected] format over the sharing dialogue.

Acceptance tests scenarios have been added - see 2nd commit.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

Merging #384 into master will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master     #384   +/-   ##
=========================================
  Coverage     17.85%   17.85%           
  Complexity       96       96           
=========================================
  Files            11       11           
  Lines           532      532           
=========================================
  Hits             95       95           
  Misses          437      437

Impacted Files	Coverage Δ	Complexity Δ
lib/Controller/UsersController.php	0% <0%> (ø)	10 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceb68cb...0bd4d32. Read the comment docs.

[phil-davis]

Assigned myself so I see this tomorrow and add some test scenario(s) for a guest with +
Also there are a couple of other guest acceptance test PRs to be merged tomorrow morning - so I will rebase after that...

[phil-davis]

Rebased just now. The code in core master is getting closer to 10.4 happening, so time to look at this again.

[CLAassistant]

All committers have signed the CLA.

[phil-davis]

@HanaGemela @micbar a guests app release is needed.
IMO that release should set core min-version to 10.4
Otherwise sites could install the new guests app on a core 10.3.2 system, the guests app would allow + in a guest email/username but core would reject a username like that, and something might go 💥