Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo bug with conflicting names #59

Closed
wants to merge 1 commit into from

Conversation

stan-is-hate
Copy link
Contributor

@stan-is-hate stan-is-hate commented May 7, 2024

E.g.:

Failed to call out to plugin - Request to configure interaction failed: Failed to process protobuf: Message Point has no field 'latitude'. Fields are {"zlatitude", "zlongitude"}

Root cause:
https://github.com/pactflow/pact-protobuf-plugin/blob/main/src/mock_server.rs#L251
multiple calls to find_message_type_by_name ignore service name. This can cause issues when either configuring interactions or later when verifying it. Configuring interaction might go through if the fields are similar between two protos, e.g. if proto A1 and A2 have a common subset of fields, then if you only use that common subset when configuring interaction, it will be successful; however validation will fail because of the non-common part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant