demo bug with conflicting names #59
Closed
+99
−55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g.:
Root cause:
https://github.com/pactflow/pact-protobuf-plugin/blob/main/src/mock_server.rs#L251
multiple calls to
find_message_type_by_name
ignore service name. This can cause issues when either configuring interactions or later when verifying it. Configuring interaction might go through if the fields are similar between two protos, e.g. if proto A1 and A2 have a common subset of fields, then if you only use that common subset when configuring interaction, it will be successful; however validation will fail because of the non-common part.