[DEV-1983][DEV-1986] Add function to subscribe and unsubscribe contact from active campaign list #1257
+91
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3d530c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
marcobottaro
changed the title
Jira Pull Request LinkThis Pull Request refers to the following Jira issue DEV-1983 |
marcobottaro
requested changes
Nov 26, 2024
Comment on lines
+3
to
+4
| // remove .skip to run the test, be aware it does real API calls | ||
| describe('manage list subscription', () => { |
There was a problem hiding this comment.
What skip?
Suggested change
| // remove .skip to run the test, be aware it does real API calls | |
| describe('manage list subscription', () => { | |
| // remove .skip to run the test, be aware it does real API calls | |
| describe.skip('manage list subscription', () => { |
| const cognitoUserId = '66ae52a0-f051-7080-04a1-465b3a4f44cc'; | ||
| const listName = 'test-webinar-1732097286071'; | ||
|
|
||
| it('should subscriber the contact to the list', async () => { |
There was a problem hiding this comment.
Suggested change
| it('should subscriber the contact to the list', async () => { | |
| it('should subscribe the contact to the list', async () => { |
| }; | ||
| } | ||
|
|
||
| const listId = await acClient.getListIdByName(listName); |
There was a problem hiding this comment.
What if the listId does not exist?
| import { acClient } from '../utils/activeCampaignClient'; | ||
|
|
||
| export async function manageListSubscription( | ||
| username: string, |
There was a problem hiding this comment.
what is the proper name of this attribute cognitoId, cognitoUserId or username?
|
|
||
| // remove .skip to run the test, be aware it does real API calls | ||
| describe('manage list subscription', () => { | ||
| const cognitoUserId = '66ae52a0-f051-7080-04a1-465b3a4f44cc'; |
There was a problem hiding this comment.
what is the proper name of this constant cognitoId, cognitoUserId or username?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Add function to subscribe and unsubscribe contact from active campaign list
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: