-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEV-1983][DEV-1986] Add function to subscribe and unsubscribe contact from active campaign list #1257
Open
tommaso1
wants to merge
4
commits into
main
Choose a base branch
from
dev-1983-and-dev-1986
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[DEV-1983][DEV-1986] Add function to subscribe and unsubscribe contact from active campaign list #1257
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3d530c3
Add function to subscribe and upsubscribe contact from active campaig…
petros-double-test1 3140e89
Update packages/active-campaign-client/src/__tests__/handlers/manageL…
tommaso1 5b7823a
Update packages/active-campaign-client/src/__tests__/handlers/manageL…
tommaso1 6cf14c2
pr comments
petros-double-test1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"active-campaign-client": minor | ||
--- | ||
|
||
Add function to subscribe and upsubscribe contact from active campaign list |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
packages/active-campaign-client/src/__tests__/helpers/manageListSubscription.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
// remove .skip to run the test, be aware it does real API calls | ||
import { manageListSubscription } from '../../helpers/manageListSubscription'; | ||
|
||
describe.skip('manage list subscription', () => { | ||
const cognitoUserId = process.env.COGNITO_USER_ID || ''; | ||
const listName = process.env.LIST_NAME || ''; | ||
|
||
it('should subscribe the contact to the list', async () => { | ||
const result = await manageListSubscription( | ||
cognitoUserId, | ||
listName, | ||
'subscribe' | ||
); | ||
|
||
expect(result.statusCode).toBe(200); | ||
}); | ||
|
||
it('should unsubscribe the contact from the list', async () => { | ||
const result = await manageListSubscription( | ||
cognitoUserId, | ||
listName, | ||
'unsubscribe' | ||
); | ||
expect(result.statusCode).toBe(200); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
packages/active-campaign-client/src/helpers/manageListSubscription.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,40 @@ | ||||||
import { APIGatewayProxyResult } from 'aws-lambda'; | ||||||
import { acClient } from '../clients/activeCampaignClient'; | ||||||
|
||||||
export async function manageListSubscription( | ||||||
cognitoUserId: string, | ||||||
listName: string, | ||||||
action: 'subscribe' | 'unsubscribe' | ||||||
): Promise<APIGatewayProxyResult> { | ||||||
try { | ||||||
const contactId = await acClient.getContactByCognitoId(cognitoUserId); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
if (!contactId) { | ||||||
return { | ||||||
statusCode: 404, | ||||||
body: JSON.stringify({ message: 'Contact not found' }), | ||||||
}; | ||||||
} | ||||||
|
||||||
const listId = await acClient.getListIdByName(listName); | ||||||
|
||||||
if (action == 'subscribe') { | ||||||
const response = await acClient.addContactToList(contactId, listId); | ||||||
return { | ||||||
statusCode: 200, | ||||||
body: JSON.stringify(response), | ||||||
}; | ||||||
} else { | ||||||
const response = await acClient.removeContactFromList(contactId, listId); | ||||||
return { | ||||||
statusCode: 200, | ||||||
body: JSON.stringify(response), | ||||||
}; | ||||||
} | ||||||
} catch (error) { | ||||||
console.error('Error:', error); | ||||||
return { | ||||||
statusCode: 500, | ||||||
body: JSON.stringify({ message: 'Internal server error' }), | ||||||
}; | ||||||
} | ||||||
} |
4 changes: 2 additions & 2 deletions
4
packages/active-campaign-client/src/types/listStatusPayload.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
export type ListStatusPayload = { | ||
readonly contactList: { | ||
readonly list: string; | ||
readonly list: number; | ||
readonly contact: string; | ||
readonly status: string; | ||
readonly status: number; | ||
}; | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.