Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgraded the app with scheduler module to SDK v0.50 #1044

Merged
merged 2 commits into from
Dec 15, 2023
Merged

feat: upgraded the app with scheduler module to SDK v0.50 #1044

merged 2 commits into from
Dec 15, 2023

Conversation

deepan95dev
Copy link
Contributor

No description provided.

byte-bandit
byte-bandit reviewed Nov 27, 2023
View reviewed changes
x/scheduler/module.go Outdated Show resolved Hide resolved
byte-bandit
byte-bandit requested changes Nov 27, 2023
View reviewed changes
x/scheduler/types/keeper.go Outdated Show resolved Hide resolved
@aleem1314
Copy link
Contributor

Check #1036 PR review comments. Apply relevant changes here too.

@deepan95dev
Copy link
Contributor Author

Check #1036 PR review comments. Apply relevant changes here too.

done

byte-bandit
byte-bandit requested changes Dec 1, 2023
View reviewed changes
proto/palomachain/paloma/scheduler/tx.proto Outdated Show resolved Hide resolved
x/scheduler/keeper/keeper.go Outdated Show resolved Hide resolved
x/scheduler/keeper/msg_server.go Outdated Show resolved Hide resolved
x/scheduler/types/msgs.go Outdated Show resolved Hide resolved
This was referenced Dec 1, 2023
Merged
Merged
Merged
aleem1314
aleem1314 suggested changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still there are few things need to be updated.
Check #1036 (review)

@aleem1314
Copy link
Contributor

@deepan95dev resolve conflicts

byte-bandit
byte-bandit requested changes Dec 11, 2023
View reviewed changes
x/scheduler/types/msgs.go Outdated Show resolved Hide resolved
x/scheduler/types/msgs.go Outdated Show resolved Hide resolved
aleem1314
aleem1314 reviewed Dec 11, 2023
View reviewed changes
app/app.go Outdated Show resolved Hide resolved
aleem1314
aleem1314 reviewed Dec 11, 2023
View reviewed changes
app/app.go Outdated Show resolved Hide resolved
byte-bandit
byte-bandit reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@byte-bandit byte-bandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please clean up unused files and make sure the linters run successfully.

Revisit your commit history to stash and fixup where useful. Please use convential commits and make sure you sign your commits.

@deepan95dev
Copy link
Contributor Author

LGTM. Please clean up unused files and make sure the linters run successfully.

Revisit your commit history to stash and fixup where useful. Please use convential commits and make sure you sign your commits.

noted. Will follow the commit conventions and verified signatures for further commits.

byte-bandit
byte-bandit previously approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@byte-bandit byte-bandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, final review to @aleem1314

aleem1314
aleem1314 previously approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment. Pre approving

@deepan95dev deepan95dev dismissed stale reviews from aleem1314 and byte-bandit via 9a17cd2 December 14, 2023 05:51
@deepan95dev
Copy link
Contributor Author

@byte-bandit rebase and fixup done.

taariq
taariq approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@taariq taariq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@byte-bandit @verabehr approving for merge.

@taariq
Copy link
Contributor

taariq commented Dec 14, 2023

@aleem1314 requires your approval here on review.

@aleem1314 aleem1314 closed this Dec 15, 2023
@aleem1314 aleem1314 reopened this Dec 15, 2023
@taariq taariq merged commit f02a835 into v0.50.0-upgrade Dec 15, 2023
0 of 4 checks passed
@taariq taariq deleted the scheduler-fixes branch December 15, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleem1314 aleem1314 aleem1314 approved these changes

@taariq taariq taariq approved these changes

@byte-bandit byte-bandit byte-bandit left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deepan95dev @aleem1314 @taariq @byte-bandit