Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Unintentional condition removed for AbortController setup #77

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

aarne
Copy link
Contributor

@aarne aarne commented Sep 24, 2024

Small logic fix and one small typo

@dagnelies
Copy link
Collaborator

Well, it's not really a logic mistake since this AbortController is only needed for the autocomplete / conditional-ui which is running in the background. For the normal authenticate/register "prompt", the function returns as soon as the user confirms or cancels the modal dialog. But well, always adding the AbortController should do no harm either.

@dagnelies dagnelies merged commit 7ccda42 into passwordless-id:main Sep 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants