Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Unintentional condition removed for AbortController setup #77

Merged
merged 1 commit into from
Sep 25, 2024
Merged

feat: Unintentional condition removed for AbortController setup #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ export async function authenticate(options: AuthenticateOptions): Promise<Authen
throw new Error('Provided challenge is not properly encoded in Base64url')

if (options.autocomplete && !(await isAutocompleteAvailable()))
throw new Error('PAsskeys autocomplete with conditional mediation is not available in this browser.')
throw new Error('Passkeys autocomplete with conditional mediation is not available in this browser.')

let authOptions: WebAuthnGetOptions = {
challenge: utils.parseBase64url(options.challenge),
Expand All @@ -172,8 +172,7 @@ export async function authenticate(options: AuthenticateOptions): Promise<Authen
if(ongoingAuth != null)
ongoingAuth.abort('Cancel ongoing authentication')

if(options.autocomplete)
ongoingAuth = new AbortController();
ongoingAuth = new AbortController();

const raw = await navigator.credentials.get({
publicKey: authOptions,
Expand Down
Loading