Synchronize manual with stubs for PHP 8.4 - part 8 #4227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
commented
Dec 2, 2024
| @@ -9,7 +9,7 @@ | |||
| <refsect1 role="description"> | |||
| &reftitle.description; | |||
| <methodsynopsis> | |||
| <type>int</type><methodname>xml_parse_into_struct</methodname> | |||
| <type class="union"><type>int</type><type>false</type></type><methodname>xml_parse_into_struct</methodname> | |||
There was a problem hiding this comment.
These signatures were forgotten to be updated when the relevant parameter descriptions were changed.
cmb69
reviewed
Dec 2, 2024
| @@ -75,7 +75,8 @@ | |||
| <listitem> | |||
| <para> | |||
| An <type>array</type> whose keys are field names in the table <parameter>table_name</parameter>, | |||
| and whose values are the conditions that a row must meet to be retrieved. | |||
| and whose values are the conditions that a row must meet to be retrieved. As of PHP 8.4.0, | |||
| if an empty array is provided, no conditions will apply. | |||
There was a problem hiding this comment.
Maybe add that the function failed for an empty array, previously.
There was a problem hiding this comment.
I hope the added sentence doesn't sound very bad
| <row> | ||
| <entry>8.4.0</entry> | ||
| <entry> | ||
| <parameter>conditions</parameter> is now nullable. |
There was a problem hiding this comment.
Doesn't look nullable; it's just that the parameter is now optional.
There was a problem hiding this comment.
Ah no, I wanted to write "optional" :)
Girgias
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.