-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronize manual with stubs for PHP 8.4 - part 8 #4227
Changes from 3 commits
310d765
532c114
9968394
07c0d11
956285c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,7 @@ | |
<type class="union"><type>array</type><type>string</type><type>false</type></type><methodname>pg_select</methodname> | ||
<methodparam><type>PgSql\Connection</type><parameter>connection</parameter></methodparam> | ||
<methodparam><type>string</type><parameter>table_name</parameter></methodparam> | ||
<methodparam><type>array</type><parameter>conditions</parameter></methodparam> | ||
<methodparam choice="opt"><type>array</type><parameter>conditions</parameter><initializer>[]</initializer></methodparam> | ||
<methodparam choice="opt"><type>int</type><parameter>flags</parameter><initializer><constant>PGSQL_DML_EXEC</constant></initializer></methodparam> | ||
<methodparam choice="opt"><type>int</type><parameter>mode</parameter><initializer><constant>PGSQL_ASSOC</constant></initializer></methodparam> | ||
</methodsynopsis> | ||
|
@@ -75,7 +75,8 @@ | |
<listitem> | ||
<para> | ||
An <type>array</type> whose keys are field names in the table <parameter>table_name</parameter>, | ||
and whose values are the conditions that a row must meet to be retrieved. | ||
and whose values are the conditions that a row must meet to be retrieved. As of PHP 8.4.0, | ||
if an empty array is provided, no conditions will apply. | ||
</para> | ||
</listitem> | ||
</varlistentry> | ||
|
@@ -132,6 +133,12 @@ | |
</row> | ||
</thead> | ||
<tbody> | ||
<row> | ||
<entry>8.4.0</entry> | ||
<entry> | ||
<parameter>conditions</parameter> is now nullable. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doesn't look nullable; it's just that the parameter is now optional. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah no, I wanted to write "optional" :) |
||
</entry> | ||
</row> | ||
&pgsql.changelog.connection-object; | ||
<row> | ||
<entry>7.1.0</entry> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,7 @@ | |
<refsect1 role="description"> | ||
&reftitle.description; | ||
<methodsynopsis> | ||
<type>int</type><methodname>xml_parse_into_struct</methodname> | ||
<type class="union"><type>int</type><type>false</type></type><methodname>xml_parse_into_struct</methodname> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These signatures were forgotten to be updated when the relevant parameter descriptions were changed. |
||
<methodparam><type>XMLParser</type><parameter>parser</parameter></methodparam> | ||
<methodparam><type>string</type><parameter>data</parameter></methodparam> | ||
<methodparam><type>array</type><parameter role="reference">values</parameter></methodparam> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add that the function failed for an empty array, previously.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope the added sentence doesn't sound very bad