Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of aligned_storage_t #1280

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Oct 22, 2024

aligned_storage(_t) is deprecated starting with C++23. Replace uses with alignas(...) unsigned char[...].

@msimberg msimberg self-assigned this Oct 22, 2024
Copy link

codacy-production bot commented Oct 22, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%) 100.00% (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4bb041c) 18260 13799 75.57%
Head commit (a9f1d16) 18260 (+0) 13798 (-1) 75.56% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1280) 3 3 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@msimberg
Copy link
Contributor Author

I've moved out the reenabling of SBO in any_sender to #1281.

@msimberg msimberg marked this pull request as ready for review October 23, 2024 08:21
@msimberg msimberg added this to the 0.30.0 milestone Oct 23, 2024
Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@msimberg msimberg added this pull request to the merge queue Oct 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2024
@msimberg msimberg merged commit e7642f9 into pika-org:main Oct 30, 2024
35 of 37 checks passed
@msimberg msimberg deleted the aligned-storage branch October 30, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Archive
Development

Successfully merging this pull request may close these issues.

2 participants