Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #1295 #1334

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Revert #1295 #1334

merged 1 commit into from
Nov 18, 2024

Conversation

msimberg
Copy link
Contributor

The PR passed pika's tests, but leads to uses of empty any_senders in DLA-Future. It's still unclear if the mistake is in DLA-Future or pika. Reverting the change in let_value is enough to make DLA-Future's tests pass again, but reverting the whole PR until I've investigated it further (other algorithms may have issues that we don't trigger in DLA-Future).

@msimberg msimberg added this to the 0.31.0 milestone Nov 18, 2024
@msimberg msimberg self-assigned this Nov 18, 2024
@msimberg msimberg marked this pull request as draft November 18, 2024 16:25
…er-function"

This reverts commit 2df06f7, reversing
changes made to 6c9fdf1.
@msimberg msimberg changed the title Revert #1321 Revert #1295 Nov 18, 2024
@msimberg msimberg marked this pull request as ready for review November 18, 2024 16:26
@msimberg msimberg merged commit df0cffe into pika-org:main Nov 18, 2024
21 of 25 checks passed
@msimberg msimberg deleted the revert-set-value-member branch November 18, 2024 16:26
Copy link

codacy-production bot commented Nov 18, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.03% (target: -1.00%) 94.12% (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2df06f7) 18285 13814 75.55%
Head commit (36f287a) 18272 (-13) 13798 (-16) 75.51% (-0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1334) 51 48 94.12%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@msimberg msimberg mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant