Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix-pd-recover #2475

Merged
merged 2 commits into from
Jan 19, 2024
Merged

fix-pd-recover #2475

merged 2 commits into from
Jan 19, 2024

Conversation

yiduoyunQ
Copy link
Contributor

First-time contributors' checklist

What is changed, added, or deleted? (Required)

When using alive PD to recreate pd cluster, there is no need to restart TiDB and TiKV, see TiUP related doc https://docs.pingcap.com/zh/tidb/stable/pd-recover#%E7%AC%AC-5-%E6%AD%A5%E6%89%A9%E5%AE%B9-pd-%E5%B9%B6%E5%90%AF%E5%8A%A8%E9%9B%86%E7%BE%A4

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)
  • v1.2 (TiDB Operator 1.2 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 4, 2023
@yiduoyunQ
Copy link
Contributor Author

hi @KanShiori please take a look, thanks.

@yiduoyunQ
Copy link
Contributor Author

hi @ran-huang please take a look when you have time, thanks.

ran-huang
ran-huang reviewed Dec 26, 2023
View reviewed changes
en/pd-recover.md Outdated Show resolved Hide resolved
ran-huang
ran-huang reviewed Dec 26, 2023
View reviewed changes
en/pd-recover.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 26, 2023
@ran-huang ran-huang requested a review from csuzhangxc December 26, 2023 08:07
@ran-huang ran-huang added needs-cherry-pick-release-1.2 Should cherry pick this PR to release-1.2 branch. needs-cherry-pick-release-1.3 Should cherry pick this PR to release-1.3 branch. needs-cherry-pick-release-1.4 Should cherry pick this PR to release-1.4 branch. needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Dec 26, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Dec 26, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 28, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-26 08:07:13.523333307 +0000 UTC m=+1553124.560560257: ☑️ agreed by ran-huang.
  • 2023-12-28 02:47:58.331469881 +0000 UTC m=+1706769.368696794: ☑️ agreed by csuzhangxc.

@yiduoyunQ
Copy link
Contributor Author

/approve

1 similar comment
@ran-huang
Copy link
Contributor

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang, yiduoyunQ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit c9ecd26 into pingcap:master Jan 19, 2024
13 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.2: #2490.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 19, 2024
Merged
6 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.3: #2491.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 19, 2024
Merged
6 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 19, 2024
Merged
6 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.4: #2492.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 19, 2024
Merged
6 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.5: #2493.

ti-chi-bot bot pushed a commit that referenced this pull request Jan 19, 2024
@ti-chi-bot
fix-pd-recover (#2475) (#2492)
2ee3396
ti-chi-bot bot pushed a commit that referenced this pull request Jan 19, 2024
@ti-chi-bot
fix-pd-recover (#2475) (#2490)
679f8c0
ti-chi-bot bot pushed a commit that referenced this pull request Jan 19, 2024
@ti-chi-bot
fix-pd-recover (#2475) (#2491)
96f3ff9
ti-chi-bot bot pushed a commit that referenced this pull request Jan 19, 2024
@ti-chi-bot
fix-pd-recover (#2475) (#2493)
c3f64d0
@yiduoyunQ yiduoyunQ deleted the fix-pd-recover branch January 19, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang approved these changes

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-1.2 Should cherry pick this PR to release-1.2 branch. needs-cherry-pick-release-1.3 Should cherry pick this PR to release-1.3 branch. needs-cherry-pick-release-1.4 Should cherry pick this PR to release-1.4 branch. needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yiduoyunQ @ran-huang @ti-chi-bot @csuzhangxc