Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zh: support PD micro service #2478
zh: support PD micro service #2478
Changes from 1 commit
8c5cf9e
7b82501
d983076
d9babd6
06579eb
14848fc
07381da
eef5485
daa875e
e9594ca
0544c54
2e0b1c1
e7bedab
e40e88a
9e971c2
20e150f
456870b
8f7353b
c330026
d1c0c27
b37489f
c24103d
c313ef6
4da0176
692220d
866ba23
b9dfd57
f697ea0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
请问 https://docs.pingcap.com/zh/tidb/stable/pd-configuration-file 里现在有这些 PD 微服务配置参数吗,还是说需要单独加到 Add pd microservices section by rleungx · Pull Request #16257 · pingcap/docs-cn 里呢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PD 微服务配置参数目前和 PD 本身都是一样的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里要不要介绍一下当前版本都支持哪些微服务,最好有个 doc link 出去?看举例介绍只有 tso,scheduling,这就是全部?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
目前只有 tso 和 schedule 两个。要不关联到这个文档?https://github.com/pingcap/docs-cn/pull/16257/files#diff-c3340841cc6bf8a5d0fdd646f8491802ad6459f18c62b9ec92966cb3bdcd9258R10-R11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
请问这里提到的“Config 配置” 就是下面截图里的配置吗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不是的,pdms 字段下的各个服务带有 config,类似:
pdms:
- name: "tso"
- config: {}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
”升级 PD 微服务版本“ 需要在 “升级 TiProxy 版本” 之前完成是吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是的,PD 微服务是最先更新的