Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zh: support PD micro service #2478

Merged
merged 28 commits into from
Mar 25, 2024
Merged

zh: support PD micro service #2478

merged 28 commits into from
Mar 25, 2024

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Dec 15, 2023

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@ti-chi-bot ti-chi-bot bot added first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 15, 2023
@CLAassistant
Copy link

CLAassistant commented Dec 15, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 15, 2023
@HuSharp HuSharp mentioned this pull request Jan 2, 2024
Merged
2 tasks
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 3, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HuSharp
update
8c5cf9e 
Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp marked this pull request as ready for review February 22, 2024 07:36
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2024
qiancai
qiancai reviewed Feb 23, 2024
View reviewed changes
zh/configure-a-tidb-cluster.md Outdated

`spec.pd.config.mode` 用于配置 PD 微服务模式，目前支持 "ms"、"" 两种模式，"ms" 表示开启微服务模式，"" 为空表示关闭微服务模式。

`spec.pdms.config` 用于配置 PD 微服务，配置参数与 `spec.pd.config` 相同，获取所有可以配置的 PD 微服务配置参数，请参考 [PD 配置文档](https://docs.pingcap.com/zh/tidb/stable/pd-configuration-file)。
Copy link
Collaborator

@qiancai qiancai Feb 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请问 https://docs.pingcap.com/zh/tidb/stable/pd-configuration-file 里现在有这些 PD 微服务配置参数吗，还是说需要单独加到 Add pd microservices section by rleungx · Pull Request #16257 · pingcap/docs-cn 里呢

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PD 微服务配置参数目前和 PD 本身都是一样的

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里要不要介绍一下当前版本都支持哪些微服务，最好有个 doc link 出去？看举例介绍只有 tso，scheduling，这就是全部？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前只有 tso 和 schedule 两个。要不关联到这个文档？https://github.com/pingcap/docs-cn/pull/16257/files#diff-c3340841cc6bf8a5d0fdd646f8491802ad6459f18c62b9ec92966cb3bdcd9258R10-R11

@qiancai qiancai self-assigned this Feb 23, 2024
@qiancai qiancai added tidb/v8.0 translation/doing This PR’s assignee is translating this PR. labels Feb 23, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Feb 23, 2024
csuzhangxc
csuzhangxc reviewed Feb 27, 2024
View reviewed changes
zh/configure-a-tidb-cluster.md Outdated Show resolved Hide resolved
zh/configure-a-tidb-cluster.md Outdated Show resolved Hide resolved
zh/configure-a-tidb-cluster.md Outdated Show resolved Hide resolved
zh/deploy-tidb-cluster-across-multiple-kubernetes.md Outdated Show resolved Hide resolved
zh/upgrade-a-tidb-cluster.md Outdated Show resolved Hide resolved
@HuSharp
address comment
7b82501 
Signed-off-by: husharp <[email protected]>
csuzhangxc
csuzhangxc reviewed Feb 27, 2024
View reviewed changes
zh/configure-a-tidb-cluster.md Outdated Show resolved Hide resolved
zh/configure-a-tidb-cluster.md Outdated Show resolved Hide resolved
@HuSharp
address comment
d983076 
Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 27, 2024
@HuSharp
add watch status
d9babd6 
Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp mentioned this pull request Feb 28, 2024
Closed
qiancai
qiancai reviewed Mar 1, 2024
View reviewed changes
zh/configure-a-tidb-cluster.md Outdated Show resolved Hide resolved
zh/configure-a-tidb-cluster.md Outdated Show resolved Hide resolved
zh/get-started.md Outdated Show resolved Hide resolved
zh/scale-a-tidb-cluster.md Outdated Show resolved Hide resolved
zh/get-started.md Outdated Show resolved Hide resolved
zh/configure-a-tidb-cluster.md Outdated Show resolved Hide resolved
zh/configure-a-tidb-cluster.md Outdated Show resolved Hide resolved
zh/configure-a-tidb-cluster.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 21, 2024
@qiancai qiancai mentioned this pull request Mar 21, 2024
Merged
2 tasks
github-actions bot pushed a commit to qiancai/pingcap-docsite-preview that referenced this pull request Mar 21, 2024
Preview PR pingcap/docs-tidb-operator#2478 and this preview is trigge…
d1616f9 
…red from commit pingcap/docs-tidb-operator@c313ef6
lilin90
lilin90 reviewed Mar 22, 2024
View reviewed changes
zh/scale-a-tidb-cluster.md Outdated Show resolved Hide resolved
zh/modify-tidb-configuration.md Outdated Show resolved Hide resolved
zh/get-started.md Outdated Show resolved Hide resolved
lilin90
lilin90 approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 22, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-27 10:58:47.590228363 +0000 UTC m=+959616.337851470: ☑️ agreed by csuzhangxc.
  • 2024-03-22 09:54:04.482702422 +0000 UTC m=+1629671.504948810: ☑️ agreed by lilin90.

@qiancai
Copy link
Collaborator

qiancai commented Mar 25, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 25, 2024
@qiancai qiancai added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. translation/doing This PR’s assignee is translating this PR. labels Mar 25, 2024
@ti-chi-bot ti-chi-bot bot merged commit 154c622 into pingcap:master Mar 25, 2024
13 checks passed
@HuSharp HuSharp deleted the support_pd_ms branch March 25, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easonn7 easonn7 easonn7 left review comments

@rleungx rleungx rleungx left review comments

@qiancai qiancai qiancai approved these changes

@lilin90 lilin90 lilin90 approved these changes

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees

@qiancai qiancai

Labels
approved first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tidb/v8.0 translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@HuSharp @CLAassistant @qiancai @csuzhangxc @lilin90 @rleungx @easonn7